STYLE: Inconsistent namespace - base (pandas-dev#39992) #40031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
punitvara
commented
Feb 24, 2021
•
- xref STYLE Increase coverage of inconsistent-namespace-usage #39992
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Fix inconsistent namespace in apply directory.
|
Thanks @punitvara - I'll merge this one, but perhaps shall we leave some other folders for other first-time contributors? |
|
Sure @MarcoGorelli. No Problem. I will not submit new one. Is there any other issue I can look into ? Any recommendations ? |
My general advice is to look for an issue which you understand and which makes you think "wow, I can't believe this is wrong, someone needs to fix it" If you know matplotlib well, then there's lots of visualisation issues which aren't getting much attention |
|
@MarcoGorelli Thanks. Appreciate your pointers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.