-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: parallelize the number of Sphinx jobs by default #39364
Conversation
@@ -39,7 +39,7 @@ class DocBuilder: | |||
|
|||
def __init__( | |||
self, | |||
num_jobs=0, | |||
num_jobs="auto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is num_jobs
just a pandas thing? We use the -j
flag for building the Cython / C extensions so wouldn't be opposed to just using that here for consistency as well, since it matches the Sphinx docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
num_jobs
was there before; I didn't mess with the name. I like that num_jobs
is more descriptive, but certainly understand the argument for consistent…arguments 😉
does this help? |
ef849e6
to
12d0bf0
Compare
Running on Codespaces, before and after:
|
12d0bf0
to
7cd8974
Compare
can you merge master and ping on green |
02ea92f
to
97c69ef
Compare
Anyone know what the |
did you rebase on master? this should have gone away |
Seems like the problem is still there.
|
one more rebase if you pls |
Most people building docs would want that to happen as quickly as possible, so this has Sphinx use the maximum parallelism possible by default.
97c69ef
to
251d4e4
Compare
thanks @afeld |
I'm assuming most people building docs would want that to happen as quickly as possible, so this has Sphinx use the maximum parallelism possible by default. Corresponding Sphinx documentation.
closes #xxxxadded/ passedwhatsnew entry