Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/STYLE Fix misspellings exposed by codespell #39264

Merged
merged 7 commits into from
Jan 21, 2021

Conversation

zitorelova
Copy link
Contributor

@zitorelova zitorelova commented Jan 19, 2021

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zitorelova for your PR

setup.cfg Outdated
@@ -67,7 +67,7 @@ filterwarnings =
junit_family=xunit2

[codespell]
ignore-words-list=ba,blocs,coo,hist,nd,ser
ignore-words-list=ba,blocs,coo,hist,nd,ser,mose,fo,ist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are mose, fo, and ist used? It might be possible to change the examples rather than ignoring them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mose is a proper noun used in the _json_normalize example here. It could be changed to a more traditional name to avoid this.

fo is used as a variable name here. I do not think we need to change this.

ist is used as part of a valid URL here. It should not be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zitorelova

Could you change mose to another name, and fo to fd?

I'll get back to you on the URL

Copy link
Contributor Author

@zitorelova zitorelova Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made changes based on your comments. There was another instance of fo used here. I've changed some of the list entries to resolve this.

@MarcoGorelli MarcoGorelli self-requested a review January 20, 2021 20:38
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

How about now adding the following to setup.cfg:

-ignore-words-list=ba,blocs,coo,hist,nd,ser,ist
+ignore-words-list=ba,blocs,coo,hist,nd,ser
+ignore-regex=https://(\w+\.)+

and then we can run the codespell everywhere except for the test suite:

     hooks:
     -   id: codespell
         types_or: [python, rst, markdown]
-        files: ^pandas/core/
+        files: ^pandas/
+        exclude: ^pandas/tests/

@zitorelova
Copy link
Contributor Author

Just added the new changes @MarcoGorelli

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @zitorelova

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 21, 2021
@jreback jreback added this to the 1.3 milestone Jan 21, 2021
@jreback jreback merged commit c322b24 into pandas-dev:master Jan 21, 2021
@jreback
Copy link
Contributor

jreback commented Jan 21, 2021

thanks @zitorelova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants