-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/STYLE Fix misspellings exposed by codespell #39264
Conversation
zitorelova
commented
Jan 19, 2021
•
edited
Loading
edited
- partial fix for CI/STYLE extend codespell beyond pandas/core #38802
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zitorelova for your PR
setup.cfg
Outdated
@@ -67,7 +67,7 @@ filterwarnings = | |||
junit_family=xunit2 | |||
|
|||
[codespell] | |||
ignore-words-list=ba,blocs,coo,hist,nd,ser | |||
ignore-words-list=ba,blocs,coo,hist,nd,ser,mose,fo,ist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are mose
, fo
, and ist
used? It might be possible to change the examples rather than ignoring them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zitorelova
Could you change mose
to another name, and fo
to fd
?
I'll get back to you on the URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made changes based on your comments. There was another instance of fo
used here. I've changed some of the list entries to resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
How about now adding the following to setup.cfg:
-ignore-words-list=ba,blocs,coo,hist,nd,ser,ist
+ignore-words-list=ba,blocs,coo,hist,nd,ser
+ignore-regex=https://(\w+\.)+
and then we can run the codespell everywhere except for the test suite:
hooks:
- id: codespell
types_or: [python, rst, markdown]
- files: ^pandas/core/
+ files: ^pandas/
+ exclude: ^pandas/tests/
Just added the new changes @MarcoGorelli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @zitorelova
thanks @zitorelova |