Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: string indexing along index for datetimes #36179

Merged
merged 15 commits into from
Sep 24, 2020
Merged

DEPR: string indexing along index for datetimes #36179

merged 15 commits into from
Sep 24, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 7, 2020 •
edited
Loading

Let's get ourselves one less special case to worry about

jreback
jreback requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on board with this, ping when passing

@jreback jreback added Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves Datetime Datetime data dtype labels Sep 7, 2020
jreback
jreback requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the ???

@jbrockmendel
Copy link
Member Author

also the ???

placeholder before I had a PR number. just updated

@jbrockmendel
Copy link
Member Author

could use some help with the ipython directive errors

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback added this to the 1.2 milestone Sep 24, 2020
@jreback jreback merged commit e4086ec into pandas-dev:master Sep 24, 2020
@jreback
Copy link
Contributor

jreback commented Sep 24, 2020

thanks, can you add the entry to the deprecation removal issue as well when you have a sec

@jbrockmendel jbrockmendel mentioned this pull request Sep 24, 2020
Closed
@jbrockmendel jbrockmendel deleted the depr-str-date-indexing branch September 24, 2020 20:21
jorisvandenbossche
jorisvandenbossche reviewed Sep 25, 2020
View reviewed changes
doc/source/user_guide/timeseries.rst
@@ -590,24 +595,28 @@ This starts on the very first time in the month, and includes the last date and
time for the month:

.. ipython:: python
:okwarning:

dft['2013-1':'2013-2']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not actually deprecated, right? (and thus shouldn't raise a warning?)

Copy link
Member Author

@jbrockmendel jbrockmendel Sep 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think this should be deprecated too.

Edit: On further thought, not sure.

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
DEPR: string indexing along index for datetimes (pandas-dev#36179)
8d8cc27
@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DEPR: DataFrame.__getitem__[str] sometimes slices on index
3 participants
@jbrockmendel @jreback @jorisvandenbossche