Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Raise ValueError instead of bare Exception in sanitize_array #35769

Merged
merged 7 commits into from
Oct 10, 2020
Merged

BUG: Raise ValueError instead of bare Exception in sanitize_array #35769

merged 7 commits into from
Oct 10, 2020

Conversation

micahjsmith
Copy link
Contributor

@micahjsmith micahjsmith commented Aug 17, 2020 •
edited
Loading

@dsaxton dsaxton added Constructors Series/DataFrame/Index/pd.array Constructors Error Reporting Incorrect or improved errors from pandas Series Series data structure labels Aug 17, 2020
@dsaxton
Copy link
Member

dsaxton commented Aug 17, 2020

@micahjsmith Can you add a note in /doc/source/whatsnew/v1.2.0.rst (you can reference v1.1.0.rst for notes on similar changes) and also a test for the error type / message?

@micahjsmith
Copy link
Contributor Author

@dsaxton sure, working on this now

@dsaxton dsaxton added this to the 1.2 milestone Aug 19, 2020
@jreback
Copy link
Contributor

jreback commented Sep 5, 2020

@micahjsmith ping when this is updated, also see if you can track down an update any tests that just test for this raising Exception (and not ValueError).

@jreback jreback removed this from the 1.2 milestone Sep 5, 2020
@jbrockmendel
Copy link
Member

this is hit in tests.series.test_constructors.TestSeriesConstructors.test_constructor

@jbrockmendel
Copy link
Member

@micahjsmith can you update the appropriate test

@micahjsmith
Copy link
Contributor Author

@jreback @jbrockmendel updated -- sorry for the delay.

dsaxton
dsaxton approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @micahjsmith

@jbrockmendel
Copy link
Member

@micahjsmith can you merge master and ping on green

@jreback jreback added this to the 1.2 milestone Oct 10, 2020
@jreback jreback merged commit 2c30222 into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks @micahjsmith

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Oct 10, 2020
@micahjsmith @jbrockmendel
BUG: Raise ValueError instead of bare Exception in sanitize_array (pa…
8912516 
…ndas-dev#35769)
jreback pushed a commit that referenced this pull request Oct 11, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith
REF/TYP: use OpsMixin for DataFrame (#37044)
89cc5bf 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (#36989)

* CI: pin pymysql #36465 (#36847)

* CI: unpin sql to verify the bugs #36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (#37017)

* CLN: require td64 in TimedeltaBlock (#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (#35769)

* CLN: collected cleanups, warning suppression in tests (#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith @JulianWgs
REF/TYP: use OpsMixin for DataFrame (pandas-dev#37044)
a39d335 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (pandas-dev#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (pandas-dev#36989)

* CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)

* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017)

* CLN: require td64 in TimedeltaBlock (pandas-dev#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769)

* CLN: collected cleanups, warning suppression in tests (pandas-dev#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@micahjsmith
BUG: Raise ValueError instead of bare Exception in sanitize_array (pa…
b137ba4 
…ndas-dev#35769)
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith
REF/TYP: use OpsMixin for DataFrame (pandas-dev#37044)
0b7a1c8 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (pandas-dev#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (pandas-dev#36989)

* CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)

* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017)

* CLN: require td64 in TimedeltaBlock (pandas-dev#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769)

* CLN: collected cleanups, warning suppression in tests (pandas-dev#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
@micahjsmith micahjsmith deleted the micahjsmith-patch-1 branch January 25, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton approved these changes

Assignees
No one assigned
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Error Reporting Incorrect or improved errors from pandas Series Series data structure
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: pd.Series() constructor with 2d NumPy array raises bare Exception
4 participants
@micahjsmith @dsaxton @jreback @jbrockmendel