Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: DateOffset.__call__ #34171

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jorisvandenbossche
Copy link
Member

Is there an issue about this?

@jbrockmendel
Copy link
Member Author

Is there an issue about this?

No

@jreback
Copy link
Contributor

jreback commented May 14, 2020

can you add this to the deprecation removal list as well

@jreback jreback added Frequency DateOffsets Deprecate Functionality to remove in pandas labels May 14, 2020
@jbrockmendel
Copy link
Member Author

can you add this to the deprecation removal list as well

added

@jreback jreback added this to the 1.1 milestone May 14, 2020
@jorisvandenbossche
Copy link
Member

Can you then at least give a reasoning?

@jreback jreback merged commit 085af07 into pandas-dev:master May 14, 2020
@jbrockmendel
Copy link
Member Author

Can you then at least give a reasoning?

Because its entirely redundant.

@jbrockmendel jbrockmendel deleted the depr-offsets-call branch May 14, 2020 16:35
@jorisvandenbossche
Copy link
Member

Thank you. It would be helpful if you can sometimes just give a bit more explanation when opening a PR (you know, I can't read your mind ;))

@jbrockmendel
Copy link
Member Author

Thank you. It would be helpful if you can sometimes just give a bit more explanation when opening a PR (you know, I can't read your mind ;))

I'll keep that in mind. Thanks for keeping me honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants