TST: DataFrameGroupBy.shift Loses TimeZone in datetime64 columns #30153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding test case for issue GH30134
WillAyd
requested changes
Dec 9, 2019
pandas/tests/dtypes/test_dtypes.py
Outdated
| @@ -323,6 +324,13 @@ def test_tz_standardize(self): | |||
| dtype = DatetimeTZDtype("ns", dr[0].tz) | |||
| assert dtype.tz == tz | |||
|
|
|||
| def test_dfgroupby_shift_tz(self): | |||
| # GH 30134 | |||
| df = pd.DataFrame({"a": [1, 1], "date": dt.datetime.now(tz=pytz.utc)}) | |||
There was a problem hiding this comment.
Suggested change
| df = pd.DataFrame({"a": [1, 1], "date": dt.datetime.now(tz=pytz.utc)}) | |
| df = pd.DataFrame({"a": [1, 1], "date": pd.Timestamp.utcnow()}) |
Slightly more idiomatic
pandas/tests/dtypes/test_dtypes.py
Outdated
| df = pd.DataFrame({"a": [1, 1], "date": dt.datetime.now(tz=pytz.utc)}) | ||
| expected = df.dtypes["date"] | ||
| result = df.groupby("a").shift(0).dtypes["date"] | ||
| assert expected == result |
There was a problem hiding this comment.
Can you build the actual expected series and use tm.assert_series_equal(result, expected)? Should see examples of this throughout tests
jreback
requested changes
Dec 10, 2019
| @@ -1138,3 +1138,12 @@ def func(grp): | |||
|
|
|||
| expected = pd.DataFrame([2, -2, 2, 4], columns=["B"]) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
can you move to pandas/tests/groupby/test_groupby.py, near the other _shift tests
jreback
approved these changes
Dec 10, 2019
|
lgtm ping on green |
|
Thanks @tranctan |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test case for issue GH30134