Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: "{foo!r}" -> "{repr(foo)}" #batch-3 #29953

Merged
merged 18 commits into from
Dec 10, 2019
Merged

STY: "{foo!r}" -> "{repr(foo)}" #batch-3 #29953

merged 18 commits into from
Dec 10, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 2, 2019 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Dec 2, 2019 •
edited
Loading

Hello @MomIsBestFriend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-09 11:15:26 UTC

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 2, 2019
@jreback jreback added this to the 1.0 milestone Dec 2, 2019
@ShaharNaveh ShaharNaveh force-pushed the STY-repr-batch-3 branch 2 times, most recently from 748515c to 59d5ea1 Compare December 2, 2019 04:00
@ShaharNaveh ShaharNaveh changed the title STY: "foo!r" -> "repr(foo)" #batch-3 STY: "{foo!r}" -> "{repr(foo)}" #batch-3 Dec 2, 2019
@jreback
Copy link
Contributor

jreback commented Dec 2, 2019

cc @simonjayhawkins @WillAyd

WillAyd
WillAyd approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you care to look @simonjayhawkins

simonjayhawkins
simonjayhawkins reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MomIsBestFriend lgtm. one question.

pandas/core/reshape/tile.py Outdated Show resolved Hide resolved
jreback
jreback requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the repr can be removed here (you can leave the ones for more complex objects, e.g. bins

pandas/core/nanops.py Show resolved Hide resolved
pandas/core/nanops.py Outdated Show resolved Hide resolved
pandas/core/reshape/concat.py Outdated Show resolved Hide resolved
pandas/core/sorting.py Outdated Show resolved Hide resolved
pandas/core/strings.py Outdated Show resolved Hide resolved
JvPy added a commit to JvPy/pandas that referenced this pull request Dec 5, 2019
@JvPy
STY - Add repr to html.py and parsers.py - pandas-dev#29953
029ee4d
JvPy added a commit to JvPy/pandas that referenced this pull request Dec 5, 2019
@JvPy
STY - Add repr to html.py and parsers.py - pandas-dev#29953
4ea03fc
JvPy added a commit to JvPy/pandas that referenced this pull request Dec 5, 2019
@JvPy
Revert "STY - Add repr to html.py and parsers.py - pandas-dev#29953"
80e8a1a 
This reverts commit 029ee4d.
JvPy added a commit to JvPy/pandas that referenced this pull request Dec 5, 2019
@JvPy
STY - Add repr to html.py and parsers.py - pandas-dev#29953
848e542
@ShaharNaveh ShaharNaveh requested a review from jreback December 5, 2019 12:35
@ShaharNaveh ShaharNaveh mentioned this pull request Dec 5, 2019
Merged
10 tasks
jreback
jreback requested changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one repr to remove, ping on green.

pandas/core/missing.py Outdated Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented Dec 8, 2019

lgtm ping on green

@ShaharNaveh
Copy link
Member Author

ping @jreback

@simonjayhawkins simonjayhawkins merged commit 87dc029 into pandas-dev:master Dec 10, 2019
@simonjayhawkins
Copy link
Member

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the STY-repr-batch-3 branch December 10, 2019 12:08
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: "{foo!r}" -> "{repr(foo)}" #batch-3 (pandas-dev#29953)
8eb2f63
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: "{foo!r}" -> "{repr(foo)}" #batch-3 (pandas-dev#29953)
a7ca730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @pep8speaks @jreback @simonjayhawkins @WillAyd