-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Correct misuse of term high-cardinality in docs. #29811
Conversation
cardinality seems like a weird term to use here. can you suggest a clearer one? |
It's indeed a very unclear term if you don't know it, but it's also commonly used in the machine learning community for this purpose (so it's certainly a correct term, at least with the fix here). |
I agree that cardinality is the correct term here and certainly expect the target audience to be familiar with its proper usage, but I've reworded it as suggested for the benefit of those that might not be familiar with the term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM |
@gfyoung can you commit your suggestion and merge. |
@jreback : This PR didn't allow for maintainers to make changes. I will merge this and follow-up with the grammar fix. |
Thanks @ebrassell ! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff