-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add NA scalar for missing value indicator, use in StringArray. #29597
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
03f83bd
ENH: add NA scalar for missing value indicator
jorisvandenbossche c1797d5
add np.nan to arithmetic/comparison tests
jorisvandenbossche 3339eaa
use id(self) for hash
jorisvandenbossche e9d4d6a
fix api test
jorisvandenbossche 4450d2d
move to cython
jorisvandenbossche 1849a23
add examples to isna/notna docstring
jorisvandenbossche c72e3ee
Use NA scalar in string dtype (#1)
TomAugspurger 3a97782
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche 2302661
fix doctest
jorisvandenbossche 2ab592a
small edits
jorisvandenbossche 018399e
fix NA in repr
jorisvandenbossche 31290b9
Merge remote-tracking branch 'upstream/master' into NA-scalar
TomAugspurger 33fd3e0
remove redundant test
TomAugspurger 289c885
remove dead code
TomAugspurger 22de7cd
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche f8208db
fix divmod
jorisvandenbossche 371eeeb
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche 1cadeda
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche 1fcf4b7
NA -> C_NA
jorisvandenbossche f6798e5
start some docs
jorisvandenbossche 14c1434
futher doc updates
jorisvandenbossche 788a2c2
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche 1bcbab2
doc fixup
jorisvandenbossche 775cdfb
Merge remote-tracking branch 'upstream/master' into NA-scalar
jorisvandenbossche 589a961
further doc updates
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,7 @@ | |
StringDtype, | ||
BooleanDtype, | ||
# missing | ||
NA, | ||
isna, | ||
isnull, | ||
notna, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a section gotchas.truth that is very similiar, could link.