Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add NA scalar for missing value indicator, use in StringArray. #29597
ENH: add NA scalar for missing value indicator, use in StringArray. #29597
Changes from 5 commits
03f83bd
c1797d5
3339eaa
e9d4d6a
4450d2d
1849a23
c72e3ee
3a97782
2302661
2ab592a
018399e
31290b9
33fd3e0
289c885
22de7cd
f8208db
371eeeb
1cadeda
1fcf4b7
f6798e5
14c1434
788a2c2
1bcbab2
775cdfb
589a961
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put the numbers.Number check last, as it will be least performant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So numpy scalars we don't have full control over, so this means that if they are the left operand, we get some other behaviour:
(for the first case, not sure what the behaviour will be once the change in numpy is done)