DOC: PR06 docstring fixes #28807
Merged
DOC: PR06 docstring fixes #28807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, thanks for working on those @tolaa001. Just added couple of comments.
5 tasks
pandas/core/arrays/categorical.py
Outdated
| dtype : CategoricalDtype or the string "category", optional | ||
| If :class:`CategoricalDtype`, cannot be used together with | ||
| dtype : CategoricalDtype or "category", optional | ||
| If :class:`Categoarray-like, intricalDtype`, cannot be used together with |
There was a problem hiding this comment.
thanks for catching that :)
Are you going Man hackathon in November @simonjayhawkins ?
|
Thanks @tolaa001 |
|
is there much of #28724 oustanding? |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains doctrine PR06 fixes mostly doing the conversion below:
boolean to bool
string to str
integer to int
Tests unchanged
black pandas ran successfully