BUG: Fix DataFrame logical ops Series inconsistency #28741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls rebase |
|
rebased+green |
|
lgtm. I think we need a small section in whatsnew to show what has changed? (could defer if you want to do a larger section on ops changes, though maybe easier to grok in pieces). |
|
Added line in whatsnew, not a whole section. Prefer to hold off on more pending nailing down remaining inconsistencies |
|
thanks. I would add the original issues to the whatsnew that you have here (and maybe in the comments you added in ops.py) |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5284
closes #5035
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWill need to look and see if this closes anything else.
This will have a merge conflict with #28638, that is a slightly higher priority.
Not sure if this constitutes an API change as the behavior for these ops is all over the place.