Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas.io.formats.style.Styler.pipe docstring PR02 #28534

Conversation

Genza999
Copy link
Contributor

Solves:

  • Unknown parameters {*args, **kwargs :}

pandas.io.formats.style.Styler.pipe: Unknown parameters {*args, **kwargs :} in #27976

Positional arguments passed into ``func``.
**kwargs : dict, optional
A dictionary of keyword arguments passed into ``func``.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line may be causing issues.

@WillAyd WillAyd added the Docs label Sep 20, 2019
- place *args and **kwargs on different lines
- provide both *args and **kwargs with new descriptions
@Genza999 Genza999 force-pushed the pandas.io.formats.style.Styler.pipe_docstring_PR02 branch from 0882031 to 1c4e27d Compare September 20, 2019 11:40
@jreback jreback added this to the 1.0 milestone Sep 20, 2019
@WillAyd
Copy link
Member

WillAyd commented Sep 20, 2019

lgtm except merge conflict - can you fix up?

@Genza999
Copy link
Contributor Author

lgtm except merge conflict - can you fix up?

Hey @WillAyd , I happened to implement the changes in this pull request in another pull request that I implemented a number of changes and it got merged before this one. For this reason I was wondering if its okay to close this PR instead.

@WillAyd
Copy link
Member

WillAyd commented Sep 20, 2019

Sure no problem

@WillAyd WillAyd closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants