DOC: redirect from_csv search #28075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A web search for "DataFrame from CSV" leads to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html which is currently a 404, since DataFrame.from_csv was removed. Redirect it to read_csv.
jorisvandenbossche
approved these changes
Aug 23, 2019
|
Not super familiar with this file but aren't there already redirects for |
|
I think those from_csv redirects were from the old API locations to the new
ones.
This is for a removed page.
…On Fri, Aug 23, 2019 at 8:05 AM William Ayd ***@***.***> wrote:
Not super familiar with this file but aren't there already redirects for
from_csv therein? Maybe just need to be updated?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28075?email_source=notifications&email_token=AAKAOIVT5GCRF4JK5LILEF3QF7OAXA5CNFSM4ION54L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AE2FQ#issuecomment-524307734>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIRS3MHPB5MEUISX6VDQF7OAXANCNFSM4ION54LQ>
.
|
|
Cool thanks for confirming |
WillAyd
approved these changes
Aug 25, 2019
|
I assume this is for 1.0.0 but merge for whichever milestone you feel best |
gfyoung
approved these changes
Aug 26, 2019
|
@TomAugspurger did you want to merge this? |
|
I still need to check if I have the path correct first.
…On Thu, Sep 5, 2019 at 10:43 AM William Ayd ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> did you want to merge
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28075?email_source=notifications&email_token=AAKAOIXI7G3GI2P2HXKILCDQIESJZA5CNFSM4ION54L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD57TTEQ#issuecomment-528431506>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIRVR6NQH5TVY3EFPUDQIESJZANCNFSM4ION54LQ>
.
|
doc/redirects.csv
Outdated
| @@ -1579,3 +1579,6 @@ generated/pandas.unique,../reference/api/pandas.unique | |||
| generated/pandas.util.hash_array,../reference/api/pandas.util.hash_array | |||
| generated/pandas.util.hash_pandas_object,../reference/api/pandas.util.hash_pandas_object | |||
| generated/pandas.wide_to_long,../reference/api/pandas.wide_to_long | |||
|
|
|||
| # Cached searches | |||
| reference/api/pandas.DataFrame.from_csv.html,../reference/api/pandas.read_csv | |||
There was a problem hiding this comment.
I think the .html is not needed here (at leas the ones above don't have it)
|
I fixed the redirect, and tested locally that this works. |
josibake
pushed a commit
to josibake/pandas
that referenced
this pull request
Sep 29, 2019
A web search for "DataFrame from CSV" leads to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html which is currently a 404, since DataFrame.from_csv was removed. Redirect it to read_csv. Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
A web search for "DataFrame from CSV" leads to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html which is currently a 404, since DataFrame.from_csv was removed. Redirect it to read_csv. Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
A web search for "DataFrame from CSV" leads to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html which is currently a 404, since DataFrame.from_csv was removed. Redirect it to read_csv. Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
A web search for "DataFrame from CSV" leads to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html which is currently a 404, since DataFrame.from_csv was removed. Redirect it to read_csv. Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A web search for "DataFrame from CSV" leads to
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.from_csv.html
which is currently a 404, since DataFrame.from_csv was removed. Redirect
it to read_csv.
Normally we shouldn't worry about this, but I suspect this is a common search term.