Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP [DOC/EA]: developer docs for implementing Series.round/sum/etc in EA #26918
WIP [DOC/EA]: developer docs for implementing Series.round/sum/etc in EA #26918
Changes from 3 commits
0ea3548
d137a10
92d4b9b
d1bf105
81cd3cf
cb3fd56
c90c597
ee3ad20
901579e
1e253c7
696b320
e70dbb9
ab418c1
d5db7e6
d7ebacf
0fec603
54b7822
d70ffec
1296267
b8187b4
387fd68
b800b67
be69f0f
4d948fa
eef58bc
068ff61
4098825
2d94b82
5a9125b
6866b66
1f689c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base ExtensionArray class already provides a
__array__
method. And if the goal of this section is "compute on your data", I don't think that__array__
should be included here, since it involves casting to an object-dtype ndarray. I recommend removing this section, or replacing it with "As a stopgap ExtensionArray.array can always be used to convert to a NumPy array of objects, but you probably don't want that because ..."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't recommend this.