BUG: Handle NA values for ExtensionArrays in Series.count #26836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #26836 +/- ##
=========================================
+ Coverage 90.45% 91.86% +1.4%
=========================================
Files 179 179
Lines 50706 50706
=========================================
+ Hits 45866 46579 +713
+ Misses 4840 4127 -713
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26836 +/- ##
==========================================
- Coverage 91.86% 91.86% -0.01%
==========================================
Files 179 180 +1
Lines 50700 50712 +12
==========================================
+ Hits 46576 46586 +10
- Misses 4124 4126 +2
Continue to review full report at Codecov.
|
|
BaseMethodsTets.test_count seems to only exercise DataFrame.count. Is this
bug Series-only?
…On Thu, Jun 13, 2019 at 2:14 PM pilkibun ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/tests/extension/decimal/test_decimal.py
<#26836 (comment)>:
> @@ -380,6 +380,16 @@ def test_divmod_array(reverse, expected_div, expected_mod):
tm.assert_extension_array_equal(mod, expected_mod)
+def test_na_count():
hmm. Why doesn't BaseMethodsTests.test_count catch this bug then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26836?email_source=notifications&email_token=AAKAOIWZW646MUAEJ4ID543P2KL7VA5CNFSM4HX4UUN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3P5ZXQ#discussion_r293536635>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIRSWPFSKZYHCO2JKBDP2KL7VANCNFSM4HX4UUNQ>
.
|
|
yeah. more generally It shows there might be lots of bugs still present when frame methods should but don't return the same result as column by column application, due to EA changes. |
|
btw, what's the norm here, force-push or add commits after review? |
|
Add new commits.
…On Thu, Jun 13, 2019 at 2:38 PM pilkibun ***@***.***> wrote:
btw, what's the norm here, force-push or add commits after review?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26836?email_source=notifications&email_token=AAKAOIT6S3VAG4O6YH6MEKTP2KO4NA5CNFSM4HX4UUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUZ7EY#issuecomment-501850003>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIXU2BCIPD3HRWKBQTDP2KO4NANCNFSM4HX4UUNQ>
.
|
|
tests pass and I think I addressed all comments. Ready to merge? |
jorisvandenbossche
approved these changes
Jun 14, 2019
jreback
requested changes
Jun 14, 2019
|
@pilkibun can you make an ExtensionArray section, and move your release note there? |
|
added |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff