Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cast ExtensionArray to numpy ndarray before plot #25590

Merged
merged 12 commits into from
Mar 15, 2019
Merged

BUG: Cast ExtensionArray to numpy ndarray before plot #25590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b3445fc
Cast `ExtensionArray` to `nd.array` before plot.
sighingnow Mar 7, 2019
7072085
Revise.
sighingnow Mar 8, 2019
ff7314d
Remove unused import to fix the lint error.
sighingnow Mar 8, 2019
f97772f
Fix import order, revise the patch and add test with more kinds of pl…
sighingnow Mar 9, 2019
5fe4f19
Merge branch 'master' into fix-25587
sighingnow Mar 12, 2019
755e8da
Fix the import order in tests.
sighingnow Mar 12, 2019
6cf16e6
Fix CI.
sighingnow Mar 12, 2019
10e9b54
Move to 0.25.0.
sighingnow Mar 13, 2019
2c1fd7d
Copy the df and transform all columns to np.array.
sighingnow Mar 14, 2019
aafd214
Remove unused import.
sighingnow Mar 14, 2019
4095c8c
Merge branch 'master' into fix-25587
sighingnow Mar 14, 2019
3afc9eb
Rename the variable.
sighingnow Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ I/O
Plotting
^^^^^^^^

- Fixed bug where :class:`api.extensions.ExtensionArray` could not be used in matplotlib plotting (:issue:`25587`)
-
-
-
Expand Down
7 changes: 6 additions & 1 deletion pandas/plotting/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,12 @@ def _compute_plot_data(self):
if is_empty:
raise TypeError('no numeric data to plot')

# GH25587: cast ExtensionArray of pandas (IntegerArray, etc.) to
TomAugspurger marked this conversation as resolved.
Show resolved Hide resolved
# np.ndarray before plot.
numeric_data = numeric_data.copy()
for col in numeric_data:
numeric_data[col] = np.asarray(numeric_data[col])

self.data = numeric_data

def _make_plot(self):
Expand Down Expand Up @@ -1794,7 +1800,6 @@ def _plot(data, x=None, y=None, subplots=False,
)
label_name = label_kw or data.columns
data.columns = label_name

plot_obj = klass(data, subplots=subplots, ax=ax, kind=kind, **kwds)

plot_obj.generate()
Expand Down
21 changes: 20 additions & 1 deletion pandas/tests/plotting/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import pandas as pd
from pandas import (
DataFrame, MultiIndex, PeriodIndex, Series, bdate_range, date_range)
from pandas.core.arrays import integer_array
from pandas.tests.plotting.common import (
TestPlotBase, _check_plot_works, _ok_for_gaussian_kde,
_skip_if_no_scipy_gaussian_kde)
Expand Down Expand Up @@ -144,8 +145,26 @@ def test_plot(self):
result = ax.axes
assert result is axes[0]

# GH 15516
def test_integer_array_plot(self):
# GH 25587
arr = integer_array([1, 2, 3, 4], dtype="UInt32")
TomAugspurger marked this conversation as resolved.
Show resolved Hide resolved

s = Series(arr)
_check_plot_works(s.plot.line)
_check_plot_works(s.plot.bar)
_check_plot_works(s.plot.hist)
_check_plot_works(s.plot.pie)

df = DataFrame({'x': arr, 'y': arr})
_check_plot_works(df.plot.line)
_check_plot_works(df.plot.bar)
_check_plot_works(df.plot.hist)
_check_plot_works(df.plot.pie, y='y')
_check_plot_works(df.plot.scatter, x='x', y='y')
_check_plot_works(df.plot.hexbin, x='x', y='y')

def test_mpl2_color_cycle_str(self):
# GH 15516
colors = ['C' + str(x) for x in range(10)]
df = DataFrame(randn(10, 3), columns=['a', 'b', 'c'])
for c in colors:
Expand Down