Code

Interval dtype fix#25338

Code

Merged

jschendel merged 36 commits intopandas-dev:masterpandas-dev/pandas:masterfrom zangell44:interval-dtype-fixzangell44/pandas:interval-dtype-fixCopy head branch name to clipboardFeb 20, 2019

+29-12

Commits

Commits on Feb 15, 2019

• Merge pull request #1 from pandas-dev/master

  Show description for 6185319
  zangell44

  authored
  6185319

  Copy full SHA for 6185319

• interval constructor logic modified and error handling for is_dtype updated to include new TypeError

  zangell44

  committed
  1c4decd

  Copy full SHA for 1c4decd

• formatting updates for error msg

  zangell44

  committed
  d52c631

  Copy full SHA for d52c631

Commits on Feb 17, 2019

• committing latest upstream master changes to branch

  zangell44

  committed
  c1b7d7f

  Copy full SHA for c1b7d7f

• subtype check logic implemented for Interval dtype

  zangell44

  committed
  953823e

  Copy full SHA for 953823e

• tests added to ensure pd.api.types.IntervalDtype.is_dtype(IntervalA) returns false

  zangell44

  committed
  8edbbd8

  Copy full SHA for 8edbbd8

• tests added to ensure * pd.api.types.IntervalDtype(IntervalA) throws TypeError

  zangell44

  committed
  8e54308

  Copy full SHA for 8e54308

• test added to ensure pd.api.types.IntervalDtype.construct_from_string(IntervalA) throws TypeError

  zangell44

  committed
  eec5013

  Copy full SHA for eec5013

• PEP8 style issues resolved

  zangell44

  committed
  708a740

  Copy full SHA for 708a740

• more PEP8 style issues resolved

  zangell44

  committed
  9ae2afc

  Copy full SHA for 9ae2afc

• subtype checking consolidated into for loop

  zangell44

  committed
  0837c85

  Copy full SHA for 0837c85

• logic change to include issubtype must result in True

  zangell44

  committed
  c0818b6

  Copy full SHA for c0818b6

• logic change for checking datetime and timedelta dtypes

  zangell44

  committed
  dedba89

  Copy full SHA for dedba89

• extra blank line removed

  zangell44

  committed
  6914a7b

  Copy full SHA for 6914a7b

• Merge remote-tracking branch 'upstream/master' into interval-dtype-fix

  Show description for e9c18e9
  zangell44

  committed
  e9c18e9

  Copy full SHA for e9c18e9

• reset to original logic on working branch, only tests written remain committed to branch

  zangell44

  committed
  c53d69c

  Copy full SHA for c53d69c

Commits on Feb 18, 2019

• logic for string constructor and error message content updated

  zangell44

  committed
  f2d2390

  Copy full SHA for f2d2390

• construction error for IntervalA parameter moved to proper test

  zangell44

  committed
  08ea833

  Copy full SHA for 08ea833

• IntervalDtype construct_from_string tests updated to separate a bad datatype (not a string) being passed, from a bad string being passed

  zangell44

  committed
  1a5fc1b

  Copy full SHA for 1a5fc1b

• TypeError added to is_dtype exceptions, reflecting changes in the construct_from_string method

  zangell44

  committed
  f2a3bdb

  Copy full SHA for f2a3bdb

Commits on Feb 19, 2019

• formatting fixes and test update

  zangell44

  committed
  0011a80

  Copy full SHA for 0011a80

• formatting update

  zangell44

  committed
  aa581fa

  Copy full SHA for aa581fa

• construct from string formatting fixes

  zangell44

  committed
  54bcf76

  Copy full SHA for 54bcf76

• interval[foo] construct from string error moved to proper test category

  zangell44

  committed
  36f8571

  Copy full SHA for 36f8571

• IntervalA construct from string error moved to proper test category

  zangell44

  committed
  6e6fe23

  Copy full SHA for 6e6fe23

• IntervalDtype construct from string test error message handling updated, regex match in error message string was causing test to fail

  zangell44

  committed
  5547b5f

  Copy full SHA for 5547b5f

• re-ordering of logic in construct from string method for cleaner code

  zangell44

  committed
  aedc7cc

  Copy full SHA for aedc7cc

• message string altered to work with regex matching

  zangell44

  committed
  2deba07

  Copy full SHA for 2deba07

• IntervalA test re-added to construct from string testing

  zangell44

  committed
  c107ccd

  Copy full SHA for c107ccd

• error message formatting fix for PEP8

  zangell44

  committed
  989942e

  Copy full SHA for 989942e

• test added for comparing series with strings containing Interval keyword

  zangell44

  committed
  d28a0fd

  Copy full SHA for d28a0fd

• regression fix documented in whats new for v0.24.2

  zangell44

  committed
  e72bfb9

  Copy full SHA for e72bfb9

• typo fix in construct_from_string error message

  zangell44

  committed
  dfe6e99

  Copy full SHA for dfe6e99

• typo fix in construct_from_string error message

  zangell44

  committed
  f08915f

  Copy full SHA for f08915f

Commits on Feb 20, 2019

• whatsnew note adjusted for clarity and style

  zangell44

  committed
  f1fabdf

  Copy full SHA for f1fabdf

• formatting update for test_compare_series_interval_keyword

  zangell44

  committed
  1ed7f8c

  Copy full SHA for 1ed7f8c