-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixing more doc warings and wrong .. code-block :: directive (space before colon) #24650
Conversation
…ace before colon)
Codecov Report
@@ Coverage Diff @@
## master #24650 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52384 52384
==========================================
+ Hits 48390 48391 +1
+ Misses 3994 3993 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24650 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52384 52384
==========================================
+ Hits 48390 48391 +1
+ Misses 3994 3993 -1
Continue to review full report at Codecov.
|
thanks @datapythonista |
Note for the people doing/reviewing/merging PRs that touch a lot of IPython directive code blocks (eg also the linting clean-up ones, if there will still be coming more), can you please check the travis doc build log ? (there was one failure due to this PR) |
w/o automated checks that is not possible to manually do things like this |
It is perfectly possible. I do it all the time (when I judge it appropriate to check, like this PR that explicitly tried to fix a lot of ipython directives). |
it’s possible but requires more effort which we have traditionally not done if you don’t agree then we need checks |
And that is what we are working on (see the issue @datapythonista just opened) |
Using
.. code-block ::
with a space before the colon wasn't making the blocks be validated for flake8 issues. Same foripython
directive.Making sure the space is not present, and fixing flake8 errors.