Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixing more doc warings and wrong .. code-block :: directive (space before colon) #24650

Merged
merged 1 commit into from
Jan 6, 2019
Merged

DOC: Fixing more doc warings and wrong .. code-block :: directive (space before colon) #24650

merged 1 commit into from
Jan 6, 2019

Conversation

datapythonista
Copy link
Member

Using .. code-block :: with a space before the colon wasn't making the blocks be validated for flake8 issues. Same for ipython directive.

Making sure the space is not present, and fixing flake8 errors.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #24650 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24650      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52384    52384              
==========================================
+ Hits        48390    48391       +1     
+ Misses       3994     3993       -1
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43.02% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc91f4c...ce0d4e4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #24650 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24650      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52384    52384              
==========================================
+ Hits        48390    48391       +1     
+ Misses       3994     3993       -1
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43.02% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc91f4c...ce0d4e4. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 6, 2019
@jreback jreback merged commit 7c842b0 into pandas-dev:master Jan 6, 2019
@jreback
Copy link
Contributor

jreback commented Jan 6, 2019

thanks @datapythonista

@jorisvandenbossche
Copy link
Member

Note for the people doing/reviewing/merging PRs that touch a lot of IPython directive code blocks (eg also the linting clean-up ones, if there will still be coming more), can you please check the travis doc build log ? (there was one failure due to this PR)
It's a bit annoying not to be able to rely on the CI status for that, but that is the reality for now.

@jreback
Copy link
Contributor

jreback commented Jan 7, 2019

w/o automated checks that is not possible to manually do things like this

@jorisvandenbossche
Copy link
Member

It is perfectly possible. I do it all the time (when I judge it appropriate to check, like this PR that explicitly tried to fix a lot of ipython directives).

@jreback
Copy link
Contributor

jreback commented Jan 7, 2019

it’s possible but requires more effort which we have traditionally not done
green means it passes

if you don’t agree then we need checks

@jorisvandenbossche
Copy link
Member

if you don’t agree then we need checks

And that is what we are working on (see the issue @datapythonista just opened)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants