DEPR: Undeprecate period - integer addition

[TomAugspurger]

Closes #24305

[pep8speaks]

Hello @TomAugspurger! Thanks for submitting the PR.

• There are no PEP8 issues in the file pandas/core/arrays/datetimelike.py !

• There are no PEP8 issues in the file pandas/tests/arithmetic/test_period.py !

• There are no PEP8 issues in the file pandas/tests/scalar/period/test_asfreq.py !

• There are no PEP8 issues in the file pandas/tests/scalar/period/test_period.py !

[TomAugspurger]

These repeated if checks could maybe be moved into the maybe_integer_op_deprecated. @jbrockmendel is there a recommended Cython equivalent for is_period_dtype?

[codecov]

Codecov Report

Merging #24352 into master will decrease coverage by 49.3%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master   #24352       +/-   ##
===========================================
- Coverage   92.29%   42.99%   -49.31%     
===========================================
  Files         162      162               
  Lines       51808    51812        +4     
===========================================
- Hits        47817    22277    -25540     
- Misses       3991    29535    +25544

Flag	Coverage Δ
#multiple	?
#single	42.99% <0%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	48.89% <0%> (-47.55%)	⬇️
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/core/categorical.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-98.65%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-95.46%)	⬇️
pandas/io/sas/sas7bdat.py	0% <0%> (-91.17%)	⬇️
pandas/io/sas/sas_xport.py	0% <0%> (-90.15%)	⬇️
... and 121 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c33b0...d2351bf. Read the comment docs.

[codecov]

Codecov Report

Merging #24352 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24352      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51808    51812       +4     
==========================================
+ Hits        47817    47821       +4     
  Misses       3991     3991

Flag	Coverage Δ
#multiple	90.7% <100%> (ø)	⬆️
#single	42.99% <0%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
pandas/core/arrays/datetimelike.py	96.47% <100%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c33b0...d2351bf. Read the comment docs.

[jreback]

thanks @TomAugspurger