Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Follow-up to #24100 #24116

Merged
merged 5 commits into from
Dec 5, 2018
Merged

CLN: Follow-up to #24100 #24116

merged 5 commits into from
Dec 5, 2018

Conversation

jbrockmendel
Copy link
Member

Avoid 1-letter variable names
Modernize string formatting
Avoid an unnecessary level of indirection in add_datetimelike_methods for DTA/TDA/PA

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #24116 into master will increase coverage by <.01%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24116      +/-   ##
==========================================
+ Coverage    92.2%    92.2%   +<.01%     
==========================================
  Files         162      162              
  Lines       51724    51715       -9     
==========================================
- Hits        47691    47685       -6     
+ Misses       4033     4030       -3
Flag Coverage Δ
#multiple 90.6% <96.19%> (ø) ⬆️
#single 43.01% <35.23%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.46% <ø> (-0.01%) ⬇️
pandas/core/arrays/timedeltas.py 87.24% <ø> (-0.03%) ⬇️
pandas/core/frame.py 96.91% <ø> (+0.11%) ⬆️
pandas/core/arrays/datetimes.py 98.25% <ø> (-0.01%) ⬇️
pandas/core/internals/construction.py 96.64% <100%> (+0.02%) ⬆️
pandas/core/arrays/datetimelike.py 96.28% <95.5%> (-0.06%) ⬇️
pandas/util/testing.py 87.41% <0%> (-0.1%) ⬇️
pandas/core/internals/blocks.py 93.72% <0%> (ø) ⬆️
pandas/core/series.py 93.7% <0%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aead29b...43515b9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #24116 into master will increase coverage by <.01%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24116      +/-   ##
==========================================
+ Coverage    92.2%    92.2%   +<.01%     
==========================================
  Files         162      162              
  Lines       51724    51715       -9     
==========================================
- Hits        47691    47685       -6     
+ Misses       4033     4030       -3
Flag Coverage Δ
#multiple 90.6% <96.19%> (ø) ⬆️
#single 43.01% <35.23%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.46% <ø> (-0.01%) ⬇️
pandas/core/arrays/timedeltas.py 87.24% <ø> (-0.03%) ⬇️
pandas/core/frame.py 96.91% <ø> (+0.11%) ⬆️
pandas/core/arrays/datetimes.py 98.25% <ø> (-0.01%) ⬇️
pandas/core/internals/construction.py 96.64% <100%> (+0.02%) ⬆️
pandas/core/arrays/datetimelike.py 96.28% <95.5%> (-0.06%) ⬇️
pandas/util/testing.py 87.41% <0%> (-0.1%) ⬇️
pandas/core/internals/blocks.py 93.72% <0%> (ø) ⬆️
pandas/core/series.py 93.7% <0%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aead29b...43515b9. Read the comment docs.

@jreback jreback added the Clean label Dec 5, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 5, 2018
@jreback jreback merged commit 2643721 into pandas-dev:master Dec 5, 2018
@jreback
Copy link
Contributor

jreback commented Dec 5, 2018

thanks!

@jbrockmendel jbrockmendel deleted the follow branch December 6, 2018 00:15
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Dec 6, 2018
commit 28c61d770f6dfca6857fd0fa6979d4119a31129e
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date:   Thu Dec 6 12:18:19 2018 -0600

    uncomment

commit bae2e322523efc73a1344464f51611e2dc555ccb
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date:   Thu Dec 6 12:17:09 2018 -0600

    maybe fixes

commit 6cb4db05c9d6ceba3794096f0172cae5ed5f6019
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date:   Thu Dec 6 09:57:37 2018 -0600

    we back

commit d97ab57fb32cb23371169d9ed659ccfac34cfe45
Merge: a117de4 b78aa8d
Author: Tom Augspurger <tom.w.augspurger@gmail.com>
Date:   Thu Dec 6 09:51:51 2018 -0600

    Merge remote-tracking branch 'upstream/master' into disown-tz-only-rebased2

commit b78aa8d
Author: gfyoung <gfyoung17+GitHub@gmail.com>
Date:   Thu Dec 6 07:18:44 2018 -0500

    REF/TST: Add pytest idiom to reshape/test_tile (pandas-dev#24107)

commit 2993b8e
Author: gfyoung <gfyoung17+GitHub@gmail.com>
Date:   Thu Dec 6 07:17:55 2018 -0500

    REF/TST: Add more pytest idiom to scalar/test_nat (pandas-dev#24120)

commit b841374
Author: evangelineliu <hsiyinliu@gmail.com>
Date:   Wed Dec 5 18:21:46 2018 -0500

    BUG: Fix concat series loss of timezone (pandas-dev#24027)

commit 4ae63aa
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Dec 5 14:44:50 2018 -0800

    Implement DatetimeArray._from_sequence (pandas-dev#24074)

commit 2643721
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Dec 5 14:43:45 2018 -0800

    CLN: Follow-up to pandas-dev#24100 (pandas-dev#24116)

commit 8ea7744
Author: chris-b1 <cbartak@gmail.com>
Date:   Wed Dec 5 14:21:23 2018 -0600

    PERF: ascii c string functions (pandas-dev#23981)

commit cb862e4
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Dec 5 12:19:46 2018 -0800

    BUG: fix mutation of DTI backing Series/DataFrame (pandas-dev#24096)

commit aead29b
Author: topper-123 <contribute@tensortable.com>
Date:   Wed Dec 5 19:06:00 2018 +0000

    API: rename MultiIndex.labels to MultiIndex.codes (pandas-dev#23752)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants