Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: passing timedelta-like to DatetimeIndex constructor, xref #23675 #23937

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

jbrockmendel
Copy link
Member

Implements the agreed-upon portions of #23675 so we can keep moving the ball down the field.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jreback jreback added Datetime Datetime data dtype Timedelta Timedelta data type Deprecate Functionality to remove in pandas labels Nov 27, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 27, 2018
@jreback jreback changed the title Implement deprecation portion of #23675 DEPR: passing timedelta-like to DatetimeIndex constructor, xref #23675 Nov 27, 2018
@jreback
Copy link
Contributor

jreback commented Nov 27, 2018

lgtm. add to #6581 ping on green.

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #23937 into master will decrease coverage by <.01%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23937      +/-   ##
==========================================
- Coverage   92.29%   92.29%   -0.01%     
==========================================
  Files         161      161              
  Lines       51501    51523      +22     
==========================================
+ Hits        47534    47554      +20     
- Misses       3967     3969       +2
Flag Coverage Δ
#multiple 90.69% <97.36%> (ø) ⬆️
#single 42.43% <76.31%> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 96.18% <100%> (-0.02%) ⬇️
pandas/core/tools/datetimes.py 85.44% <100%> (+0.18%) ⬆️
pandas/core/arrays/datetimes.py 98.37% <95.23%> (-0.14%) ⬇️
pandas/core/ops.py 94.14% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede0dae...2792dcb. Read the comment docs.

@jbrockmendel
Copy link
Member Author

azure failure is Hypothesis. de-facto green ping

@jreback jreback merged commit c05b73f into pandas-dev:master Nov 27, 2018
@jreback
Copy link
Contributor

jreback commented Nov 27, 2018

thanks. do we need to simply raise the timeout on hypthossis?

@jbrockmendel
Copy link
Member Author

do we need to simply raise the timeout on hypthossis?

I think I saw a PR for that recently. Didn't look at it too closely. If I'm going to spend time on one minor annoyance today, it'll be the dateutil DeprecationWarning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants