Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Series.__rdivmod__, un-xfail tests #23271

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added the Numeric Operations Arithmetic, Comparison, and Logical operations label Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

do we need to add anything to extension tests to exercise this? I think we are just testing divmod atm

    def test_divmod_series_array(self, data):
        s = pd.Series(data)
        self._check_divmod_op(s, divmod, data)

in pandas/tests/extension/base/ops.py

@jbrockmendel
Copy link
Member Author

do we need to add anything to extension tests to exercise this?

I'm not very familiar with that test directory. I expect that will change after the current crop of PRs is done and I get started on Datetime/TimedeltaArray.

After Datetime/Timedelta/PeriodArray are all in place, I'm planning to add them to something like the box fixture used in tests/arithmetic. IntNA should be added there, too.

@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

ok, let me create an issue for this then.

@jreback jreback merged commit cb8a67e into pandas-dev:master Oct 23, 2018
@jbrockmendel jbrockmendel deleted the divmod branch October 23, 2018 02:59
jorisvandenbossche added a commit that referenced this pull request Oct 23, 2018
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Oct 23, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series has no __rdivmod__
2 participants