Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SparseArray.unique with all sparse #23186

Merged
merged 2 commits into from
Oct 18, 2018
Merged

BUG: SparseArray.unique with all sparse #23186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9089d6d
BUG: SparseArray.unique with all sparse
TomAugspurger Oct 16, 2018
abedfe5
fixup
TomAugspurger Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/arrays/sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ def _first_fill_value_loc(self):
return -1

indices = self.sp_index.to_int_index().indices
if indices[0] > 0:
if len(indices) == 0 or indices[0] > 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not len(indices) ?

return 0

diff = indices[1:] - indices[:-1]
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/arrays/sparse/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,6 +1065,14 @@ def test_unique_na_fill(arr, fill_value):
tm.assert_numpy_array_equal(a, b)


def test_unique_all_sparse():
# https://github.com/pandas-dev/pandas/issues/23168
arr = SparseArray([0, 0])
result = arr.unique()
expected = SparseArray([0])
tm.assert_sp_array_equal(result, expected)


def test_map():
arr = SparseArray([0, 1, 2])
expected = SparseArray([10, 11, 12], fill_value=10)
Expand Down