Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove unused param #22323

Closed
wants to merge 1 commit into from
Closed

CLN: Remove unused param #22323

wants to merge 1 commit into from

Conversation

alimcmaster1
Copy link
Member

Param no longer used. Can remove it from single caller of this function

@gfyoung gfyoung added Indexing Related to indexing on series/frames, not to indexes themselves Clean labels Aug 13, 2018
@gfyoung gfyoung requested review from jreback and toobaz and removed request for jreback August 13, 2018 20:17
@alimcmaster1 alimcmaster1 changed the title Remove unused param CLN: Remove unused param Aug 13, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so rather than do this, I would make the signature more similar to ....numeric_binop and pass op, then construct the opstr inside.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #22323 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22323   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         169      169           
  Lines       50706    50706           
=======================================
  Hits        46691    46691           
  Misses       4015     4015
Flag Coverage Δ
#multiple 90.49% <100%> (ø) ⬆️
#single 42.33% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d71f...393992c. Read the comment docs.

@toobaz
Copy link
Member

toobaz commented Aug 14, 2018

so rather than do this, I would make the signature more similar to ....numeric_binop and pass op, then construct the opstr inside.

@jreback I think this is feasible only after merging #22336 and replacing np.abs with operator.abs (no idea whether this has any side effect), because np.abs.__name__ is "absolute", not "abs".

@jreback
Copy link
Contributor

jreback commented Nov 4, 2018

closing as this is dependent on #22336 which needs to be fixed first.

@jreback jreback closed this Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants