Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: To remove extra `` to match :class: rendering requirements #21586

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 22, 2018

Removing extra `` to solve rendering issues

@TomAugspurger , I am not really much acquainted to :class: reference. Do tell me If I am wrong in the inference of the issue.
I guessed that the parameters should be enclosed in not `` by looking at the following:

Datetimelike API Changes
^^^^^^^^^^^^^^^^^^^^^^^^
- For :class:`DatetimeIndex` and :class:`TimedeltaIndex` with non-``None`` ``freq`` attribute, addition or subtraction of integer-dtyped array or ``Index`` will return an object of the same class (:issue:`19959`)
- :class:`DateOffset` objects are now immutable. Attempting to alter one of these will now raise ``AttributeError`` (:issue:`21341`)

Removing extra `` to solve rendering issues
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #21586 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21586      +/-   ##
==========================================
+ Coverage    91.9%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49549    49549              
==========================================
+ Hits        45537    45539       +2     
+ Misses       4012     4010       -2
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.27% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ffc5f...1eb0cf3. Read the comment docs.

@gfyoung gfyoung added the Docs label Jun 22, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good!

cc @TomAugspurger @jreback

@jreback jreback added this to the 0.24.0 milestone Jun 22, 2018
@jreback jreback merged commit bd1b04e into pandas-dev:master Jun 22, 2018
@jreback
Copy link
Contributor

jreback commented Jun 22, 2018

thanks, this only partially closes as for 2) in the issue.

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants