Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: multi_take is now able to tackle all list-like (non-bool) cases #21569

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Jun 21, 2018

  • tests passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

This is basically a consequence of #21503 - the code path for indexing when key is a collection is now the same for multi_take and for single take.

(Next step will be to merge the other code paths too, and approach with multi_take all cases in which mutiple axes are being indexed, in whatever fashion)

@toobaz toobaz added Refactor Internal refactoring of code Indexing Related to indexing on series/frames, not to indexes themselves labels Jun 21, 2018
@toobaz toobaz force-pushed the allow_more_multi_take branch from 145341a to 430a268 Compare June 21, 2018 09:37
@jreback jreback added this to the 0.24.0 milestone Jun 21, 2018
@jreback
Copy link
Contributor

jreback commented Jun 21, 2018

lgtm. merge on green.

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #21569 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21569      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         153      153              
  Lines       49561    49553       -8     
==========================================
- Hits        45559    45551       -8     
  Misses       4002     4002
Flag Coverage Δ
#multiple 90.32% <100%> (-0.01%) ⬇️
#single 41.8% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexing.py 93.37% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fba9e...430a268. Read the comment docs.

@toobaz toobaz merged commit f1ffc5f into pandas-dev:master Jun 21, 2018
@toobaz toobaz deleted the allow_more_multi_take branch June 21, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants