-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: IntervalIndex[IntervalArray] #20611
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9b8564f
REF: IntervalIndex[IntervalArray]
TomAugspurger 9e5fc50
fixup! REF: IntervalIndex[IntervalArray]
TomAugspurger abb8a45
fixup! fixup! REF: IntervalIndex[IntervalArray]
TomAugspurger 4e48e88
Py2 compat
TomAugspurger 11d97db
DOC: Added note about missing comma
TomAugspurger de96a61
Added IntervalArray.__setitem__
TomAugspurger 24db222
Fixed linting
TomAugspurger d2bb35a
Fix for Joris
TomAugspurger f22b453
Update for comments
TomAugspurger 934f238
Merge remote-tracking branch 'upstream/master' into ea-ii
TomAugspurger 097b9a4
Allow setting NA
jschendel c2bca65
review edits
jschendel 39249a3
implement IntervalArray.repeat to fix failing tests
jschendel f82df72
cleanup tests
jschendel e0fe0bc
additional review fixups
jschendel 7c0ffd3
rename exceptions.py -> _exceptions.py
jschendel e89d89a
resolve merge conflicts
jschendel a33940a
fix breaking tests after merge
jschendel 382737d
move test_interval
jschendel 95f8f15
post-rebase review fixes
jschendel e82eeb6
unused import
jschendel bccb4f7
more review fixes
jschendel 99ab41f
more review fixes
jschendel 385ce59
undo parametrize in test_hasing.py and move to separate PR
jschendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__array__
has to return an ndarray. Without this, Categorical[ExtensionArray]would fail, as
take_1d(...)` would be an ExtensionArray.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an update on this section already in intna