-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update the pandas.Series.set_axis docstring #20164
Conversation
Hello @astrastefania! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 13, 2018 at 21:12 Hours UTC |
pandas/core/generic.py
Outdated
labels : list-like, Index | ||
The values for the new index. | ||
|
||
axis : int, default 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
axis : {0 or 'index', 1 or 'columns'}, default 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And modify the description to say that the string forms are also acepted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, so axis : {0 or 'index', 1 or 'columns'}, default 0 is enough or should I mention int, str
too?
d96c80e
to
ec1c752
Compare
OK, I added the fixes mentioned :) |
Codecov Report
@@ Coverage Diff @@
## master #20164 +/- ##
=========================================
Coverage ? 91.7%
=========================================
Files ? 150
Lines ? 49152
Branches ? 0
=========================================
Hits ? 45074
Misses ? 4078
Partials ? 0
Continue to review full report at Codecov.
|
Pushed an update. We weren't actually using the @astrastefania let me know if you see that the test finish before I do. |
Hey @TomAugspurger, should I update anything in here? |
I think those failures are unrelated. Will look more closely tomorrow.
…________________________________
From: Stefania Delprete <notifications@github.com>
Sent: Thursday, March 15, 2018 5:06:38 PM
To: pandas-dev/pandas
Cc: Tom Augspurger; Mention
Subject: Re: [pandas-dev/pandas] DOC: update the pandas.Series.set_axis docstring (#20164)
Hey @TomAugspurger<https://github.com/tomaugspurger>, should I update anything in here?
I'm happy to understand better how CircleCI works. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20164 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIt0PrfFNqDnh_2x4OueWdmjSln0Cks5teuXugaJpZM4SlTV0>.
|
@astrastefania those failures were fixed by #20288. It failed on CircleCI since it tests your exact branch, which doesn't include those changes. It passed on TravisCI since it tests a merge commit, We could merge master to this branch and repush and things should pass. But I'm just going to merge. Thanks! |
See pandas-dev/pandas#20164 Signed-off-by: Gianpaolo Macario <gmacario@gmail.com>
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.