Fix no raise dup index when using drop with axis=0 #19230

aschade · 2018-01-13T19:58:42Z

closes BUG: drop on axis with duplicate values doesn't raise when label is absent #19186
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

jschendel · 2018-01-13T20:42:36Z

doc/source/whatsnew/v0.23.0.txt

@@ -453,6 +453,7 @@ Reshaping
 - Bug in :func:`Dataframe.pivot_table` which fails when the ``aggfunc`` arg is of type string.  The behavior is now consistent with other methods like ``agg`` and ``apply`` (:issue:`18713`)
 - Bug in :func:`DataFrame.merge` in which merging using ``Index`` objects as vectors raised an Exception (:issue:`19038`)
 - Bug in :func:`DataFrame.stack`, :func:`DataFrame.unstack`, :func:`Series.unstack` which were not returning subclasses (:issue:`15563`)
+- Bug in :func:`DataFrame.drop`, `ValueError` now raises when dropping an `Index` that has duplicates


`ValueError` --> ``ValueError`` (double backticks)

`Index` --> ``Index`` (double backticks)

Add the issue number: (:issue:`19186`)

jschendel · 2018-01-13T21:01:53Z

pandas/core/generic.py

@@ -2909,6 +2909,9 @@ def _drop_axis(self, labels, axis, level=None, errors='raise'):
            else:
                indexer = ~axis.isin(labels)

+            if indexer.all() and errors == 'raise':


Actually, I might have been a little too quick to say switch to .all(). It looks like builtin all will be faster for sizable arrays that have a False early on. Leave it as is for now though, unless someone else says to switch it, since .all() should have a lower bound for the worst case scenario.

Switching the errors == 'raise' check to be first should be more efficient, since that's a cheaper check, and will cause the and to terminate before checking indexer in cases where this isn't applicable:

In [2]: a = np.repeat([True], 10**5) In [3]: errors = 'other' In [4]: %timeit errors == 'raise' and a.all() 58.7 ns ± 10 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each) In [5]: %timeit a.all() and errors == 'raise' 6.82 µs ± 856 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Ok, I'll leave it as is for now and make the other change

Looks like you're right about .all() when a value is False early on:

In[9]: arr = np.repeat([True], 1000000) In[10]: arr[15] = False In[11]: %timeit all(arr) 1.93 µs ± 193 ns per loop (mean ± std. dev. of 7 runs, 1000000 loops each) In[12]: %timeit arr.all() 244 µs ± 38.4 µs per loop (mean ± std. dev. of 7 runs, 10000 loops each)

And then when every value is True:

In[13]: arr = np.repeat([True], 1000000) In[14]: %timeit all(arr) 33.8 ms ± 5.4 ms per loop (mean ± std. dev. of 7 runs, 10 loops each) In[15]: %timeit arr.all() 131 µs ± 35.1 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

But like you said worst case is much better with .all()

jreback · 2018-01-13T22:24:21Z

pandas/tests/frame/test_mutate_columns.py

@@ -257,3 +257,21 @@ def test_insert_column_bug_4032(self):
        expected = DataFrame([[1.3, 1, 1.1], [2.3, 2, 2.2]],
                             columns=['c', 'a', 'b'])
        assert_frame_equal(result, expected)
+
+    data = [[1, 2, 3], [1, 2, 3]]


can you move to test_axis_select_reindex where the other drop tests are

jreback · 2018-01-13T22:25:01Z

pandas/core/generic.py

@@ -2909,6 +2909,9 @@ def _drop_axis(self, labels, axis, level=None, errors='raise'):
            else:
                indexer = ~axis.isin(labels)

+            if errors == 'raise' and indexer.all():
+                raise ValueError('{} not found in axis'.format(labels))


this should be a KeyError

Should line 3770 in pandas.core.indexes.base also be KeyError then?

can u show a user facing example

In[3]: pd.DataFrame(index=['a', 'b']).drop('c', axis=1) ValueError: labels ['c'] not contained in axis

if u change that,
what breaks?

It breaks 15 tests that are expecting that scenario to be a ValueError

can u show some more on this eg which tests

============================================================= FAILURES ============================================================= _______________________________________________________ TestPanel.test_drop ________________________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/test_panel.py:2305: in test_drop pytest.raises(ValueError, panel.drop, 'Three') pandas/core/generic.py:2863: in drop obj = obj._drop_axis(labels, axis, level=level, errors=errors) pandas/core/generic.py:2895: in _drop_axis new_axis = axis.drop(labels, errors=errors) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['Three'] not contained in axis" ____________________________________________ TestDataFrameSelectReindex.test_drop_names ____________________________________________ [gw1] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/frame/test_axis_select_reindex.py:44: in test_drop_names pytest.raises(ValueError, df.drop, ['g']) pandas/core/generic.py:2863: in drop obj = obj._drop_axis(labels, axis, level=level, errors=errors) pandas/core/generic.py:2895: in _drop_axis new_axis = axis.drop(labels, errors=errors) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['g'] not contained in axis" _______________________________________________ TestDataFrameSelectReindex.test_drop _______________________________________________ [gw0] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/frame/test_axis_select_reindex.py:90: in test_drop pytest.raises(ValueError, simple.drop, 5) pandas/core/generic.py:2863: in drop obj = obj._drop_axis(labels, axis, level=level, errors=errors) pandas/core/generic.py:2895: in _drop_axis new_axis = axis.drop(labels, errors=errors) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: 'labels [5] not contained in axis' _______________________________________________________ TestIndex.test_drop ________________________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1399: in test_drop pytest.raises(ValueError, self.strIndex.drop, ['foo', 'bar']) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['foo' 'bar'] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop0-values0] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['a'] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop0-values1] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['a'] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop0-values2] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels ['a'] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop1-values0] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels [('c', 'd')] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop1-values1] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels [('c', 'd')] not contained in axis" ___________________________________________ TestIndex.test_drop_tuple[to_drop1-values2] ____________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/indexes/test_base.py:1451: in test_drop_tuple pytest.raises(ValueError, removed.drop, drop_me) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: "labels [('c', 'd')] not contained in axis" _______________________________________________ TestPivotTable.test_pivot_no_values ________________________________________________ [gw3] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/reshape/test_pivot.py:214: in test_pivot_no_values res = df.pivot_table(index=df.index.month, columns=df.index.day) pandas/core/frame.py:4513: in pivot_table margins_name=margins_name) pandas/core/reshape/pivot.py:77: in pivot_table values = values.drop(key) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: 'labels [1 2 1 1 1] not contained in axis' ____________________________________________________ TestPivotTable.test_daily _____________________________________________________ [gw3] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/reshape/test_pivot.py:916: in test_daily columns=ts.index.dayofyear) pandas/core/reshape/pivot.py:77: in pivot_table values = values.drop(key) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: 'labels [2000 2000 2000 ..., 2004 2004 2004] not contained in axis' ___________________________________________________ TestPivotTable.test_monthly ____________________________________________________ [gw3] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/reshape/test_pivot.py:934: in test_monthly columns=ts.index.month) pandas/core/reshape/pivot.py:77: in pivot_table values = values.drop(key) pandas/core/indexes/base.py:3771: in drop labels[mask]) E KeyError: 'labels [2000 2000 2000 2000 2000 2000 2000 2000 2000 2000 2000 2000 2001 2001 2001\n 2001 2001 2001 2001 2001 2001 2001 2001 2001 2002 2002 2002 2002 2002 2002\n 2002 2002 2002 2002 2002 2002 2003 2003 2003 2003 2003 2003 2003 2003 2003\n 2003 2003 2003 2004 2004 2004 2004 2004 2004 2004 2004 2004 2004 2004 2004] not contained in axis' ___________________________________________________ TestSeriesIndexing.test_drop ___________________________________________________ [gw2] darwin -- Python 3.5.4 /Users/Alex/miniconda3/envs/pandas/bin/python pandas/tests/series/test_indexing.py:1841: in test_drop pytest.raises(ValueError, s.drop, 'bc') pandas/core/generic.py:2863: in drop obj = obj._drop_axis(labels, axis, level=level, errors=errors) pandas/core/generic.py:2895: in _drop_axis new_axis = axis.drop(labels, errors=errors) pandas/core/indexes/base.py:3771: in drop 'labels %s not contained in axis' % labels[mask]) E KeyError: "labels ['bc'] not contained in axis"

Wouldn't be a ton of effort to just update the tests.

yeah let me have a closer look
we could prob just change this to be a KeyError which is more consistent with other indexing

Great, thanks!

jreback · 2018-01-13T22:25:37Z

doc/source/whatsnew/v0.23.0.txt

@@ -453,6 +453,7 @@ Reshaping
 - Bug in :func:`Dataframe.pivot_table` which fails when the ``aggfunc`` arg is of type string.  The behavior is now consistent with other methods like ``agg`` and ``apply`` (:issue:`18713`)
 - Bug in :func:`DataFrame.merge` in which merging using ``Index`` objects as vectors raised an Exception (:issue:`19038`)
 - Bug in :func:`DataFrame.stack`, :func:`DataFrame.unstack`, :func:`Series.unstack` which were not returning subclasses (:issue:`15563`)
+- Bug in :func:`DataFrame.drop`, ``ValueError`` now raises when dropping an ``Index`` that has duplicates (:issue:`19186`)


can you reword (e.g. the Index now corectly raises KeyError if it has duplicates)

can you move to Bug Fixes, indexing section

jreback · 2018-01-13T22:27:41Z

pandas/tests/frame/test_mutate_columns.py

+
+    data = [[1, 2, 3], [1, 2, 3]]
+
+    @pytest.mark.parametrize('actual', [


we need to test for axis=1 case as well (see the original issue)

codecov · 2018-01-13T23:46:55Z

Codecov Report

Merging #19230 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #19230      +/-   ##
==========================================
+ Coverage   91.56%   91.56%   +<.01%     
==========================================
  Files         148      148              
  Lines       48856    48858       +2     
==========================================
+ Hits        44733    44735       +2     
  Misses       4123     4123

Flag	Coverage Δ
#multiple	`89.93% <100%> (ø)`	⬆️
#single	`41.69% <0%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/generic.py	`95.91% <100%> (ø)`	⬆️
pandas/core/indexes/base.py	`96.46% <100%> (ø)`	⬆️
pandas/core/reshape/pivot.py	`96.35% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c271d4d...5776bf3. Read the comment docs.

aschade · 2018-01-14T19:54:32Z

@jreback I updated with proposed changes

jreback · 2018-01-15T15:20:01Z

doc/source/whatsnew/v0.23.0.txt

@@ -408,6 +408,8 @@ Indexing
 - Bug in :func:`MultiIndex.set_labels` which would cause casting (and potentially clipping) of the new labels if the ``level`` argument is not 0 or a list like [0, 1, ... ]  (:issue:`19057`)
 - Bug in ``str.extractall`` when there were no matches empty :class:`Index` was returned instead of appropriate :class:`MultiIndex` (:issue:`19034`)
 - Bug in :class:`IntervalIndex` where set operations that returned an empty ``IntervalIndex`` had the wrong dtype (:issue:`19101`)
+- Bug in :func:`DataFrame.drop`, ``KeyError`` now raises when dropping an ``Index`` or column that has duplicates (:issue:`19186`)


add another entry in API breaking saysing that .drop() for Series,Index,DataFrame,Panel .drop now raises KeyError rather than ValueError if labels are missing (use this PR number)

jreback · 2018-01-15T15:20:39Z

pandas/core/indexes/base.py

@@ -3767,8 +3767,8 @@ def drop(self, labels, errors='raise'):
        mask = indexer == -1
        if mask.any():
            if errors != 'ignore':
-                raise ValueError('labels %s not contained in axis' %
-                                 labels[mask])


need to update the doc-strings for all (Index,Series,DataFrame,Panel) for drop to change ValueError -> KeyError in the Raises section (or add it if its not there)

jreback

minor comments. @TomAugspurger if you'd have a look.

jreback · 2018-01-16T00:37:19Z

doc/source/whatsnew/v0.23.0.txt

@@ -272,6 +272,7 @@ Other API Changes
 - :class:`IntervalIndex` and ``IntervalDtype`` no longer support categorical, object, and string subtypes (:issue:`19016`)
 - The default ``Timedelta`` constructor now accepts an ``ISO 8601 Duration`` string as an argument (:issue:`19040`)
 - ``IntervalDtype`` now returns ``True`` when compared against ``'interval'`` regardless of subtype, and ``IntervalDtype.name`` now returns ``'interval'`` regardless of subtype (:issue:`18980`)
+- ``KeyError`` now raises instead of ``ValueError`` when using :meth:`drop()` to remove a non-existent element in an axis of ``Series``, ``Index``, ``DataFrame`` and ``Panel`` (:issue:`19186`)


can you re-word, start with :meth:`drop()` (side issue does this render?) you may hve to say :meth:`DataFrame.drop` (and prob list for all of them Index, Series, Panel).

No, I don't think that'll render / link. I usually do

:meth:`~DataFrame.drop`

When I want to refer to a generic .drop method, which renders as .drop(), but links to DataFrame.

jreback · 2018-01-16T00:37:41Z

doc/source/whatsnew/v0.23.0.txt

@@ -415,6 +416,8 @@ Indexing
 - Bug in :func:`MultiIndex.set_labels` which would cause casting (and potentially clipping) of the new labels if the ``level`` argument is not 0 or a list like [0, 1, ... ]  (:issue:`19057`)
 - Bug in ``str.extractall`` when there were no matches empty :class:`Index` was returned instead of appropriate :class:`MultiIndex` (:issue:`19034`)
 - Bug in :class:`IntervalIndex` where set operations that returned an empty ``IntervalIndex`` had the wrong dtype (:issue:`19101`)
+- Bug in :func:`Index.drop()`, where no ``Exception`` is raised when dropping a non-existent element from an axis in ``Index`` (:issue:`19186`)


say that this will now raise a KeyError

TomAugspurger · 2018-01-16T00:54:41Z

doc/source/whatsnew/v0.23.0.txt

@@ -272,6 +272,7 @@ Other API Changes
 - :class:`IntervalIndex` and ``IntervalDtype`` no longer support categorical, object, and string subtypes (:issue:`19016`)
 - The default ``Timedelta`` constructor now accepts an ``ISO 8601 Duration`` string as an argument (:issue:`19040`)
 - ``IntervalDtype`` now returns ``True`` when compared against ``'interval'`` regardless of subtype, and ``IntervalDtype.name`` now returns ``'interval'`` regardless of subtype (:issue:`18980`)
+- ``KeyError`` now raises instead of ``ValueError`` when using :meth:`drop()` to remove a non-existent element in an axis of ``Series``, ``Index``, ``DataFrame`` and ``Panel`` (:issue:`19186`)


No, I don't think that'll render / link. I usually do

:meth:`~DataFrame.drop`

When I want to refer to a generic .drop method, which renders as .drop(), but links to DataFrame.

TomAugspurger · 2018-01-16T00:56:01Z

pandas/core/generic.py

+        Raises
+        ------
+        KeyError
+            * If labels are not found in the selected axis


Don't think you need the * here. And maybe clarify that it raises if none of the labels are found.

TomAugspurger · 2018-01-16T00:56:25Z

pandas/core/indexes/base.py

+        Raises
+        ------
+        KeyError
+            * If labels are not found in the selected axis


TomAugspurger · 2018-01-16T00:58:56Z

pandas/tests/frame/test_axis_select_reindex.py

+        # issue 19186
+        level = 0 if isinstance(actual.index, MultiIndex) else None
+        with pytest.raises(KeyError):
+            actual.drop('c', level=level, axis=0)


Split this into multiple with statements, one per exception.

jreback · 2018-01-18T00:53:18Z

thanks @aschade nice patch! keep em coming!

aschade · 2018-01-18T16:59:24Z

Will do :)

…

On Wed, Jan 17, 2018 at 7:53 PM Jeff Reback ***@***.***> wrote: thanks @aschade <https://github.com/aschade> nice patch! keep em coming! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19230 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADMMOIe17borX0hdSiipVQyoTu0oW-eCks5tLpYMgaJpZM4RdWOd> .

fix for the stricter error introduced by pandas-dev/pandas#19230

aschade added 3 commits January 13, 2018 14:55

DOC: Updated doc

d0b39ea

TST: Added test for dropping index with dup cols

f43dbf8

BUG: Raise on drop on dup index

a4618bf

aschade closed this Jan 13, 2018

aschade deleted the fix-no-raise-dup-cols branch January 13, 2018 20:04

aschade restored the fix-no-raise-dup-cols branch January 13, 2018 20:04

aschade reopened this Jan 13, 2018

jschendel reviewed Jan 13, 2018

View reviewed changes

DOC: Fixed docs

b49f78d

jschendel reviewed Jan 13, 2018

View reviewed changes

aschade force-pushed the fix-no-raise-dup-cols branch from ebd2a72 to b49f78d Compare January 13, 2018 21:03

Use numpy all

43fe5b0

aschade force-pushed the fix-no-raise-dup-cols branch from c365e0c to 43fe5b0 Compare January 13, 2018 21:12

aschade changed the title ~~Fix no raise dup cols~~ Fix no raise dup index when using drop with axis=0 Jan 13, 2018

jreback added Indexing Related to indexing on series/frames, not to indexes themselves Error Reporting Incorrect or improved errors from pandas labels Jan 13, 2018

jreback requested changes Jan 13, 2018

View reviewed changes

aschade added 3 commits January 14, 2018 14:43

TST: Updated tests to account for KeyError now being raised

7ceafa1

DOC: Moved string to diff location

5f7e6a2

BUG: Updated code to raise KeyError

6c7bcf2

DOC: Updated doc to include correct err being raised.

fa4c9fe

jorisvandenbossche mentioned this pull request Jan 15, 2018

BUG: drop on axis with duplicate values doesn't raise when label is absent #19186

Closed

jreback requested changes Jan 15, 2018

View reviewed changes

aschade and others added 4 commits January 15, 2018 13:43

DOC: Updated docstring and documentation

adf2283

Merge branch 'master' into fix-no-raise-dup-cols

c02c400

Merge branch 'master' into fix-no-raise-dup-cols

85e0094

Update v0.23.0.txt

556f959

jreback requested changes Jan 16, 2018

View reviewed changes

jreback added this to the 0.23.0 milestone Jan 16, 2018

TomAugspurger reviewed Jan 16, 2018

View reviewed changes

aschade force-pushed the fix-no-raise-dup-cols branch from bc369f3 to e31b4d2 Compare January 16, 2018 02:15

DOC/TST: Updated docstring to show method correctly and updated test

5776bf3

aschade force-pushed the fix-no-raise-dup-cols branch from e31b4d2 to 5776bf3 Compare January 16, 2018 02:18

jreback approved these changes Jan 18, 2018

View reviewed changes

jreback merged commit d7a2e94 into pandas-dev:master Jan 18, 2018

rainwoodman added a commit to rainwoodman/nbodykit that referenced this pull request May 19, 2018

update cgm for pandas-0.23.0

8a07434

fix for the stricter error introduced by pandas-dev/pandas#19230

rainwoodman mentioned this pull request May 19, 2018

update cgm for pandas-0.23.0 bccp/nbodykit#491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix no raise dup index when using drop with axis=0 #19230

Fix no raise dup index when using drop with axis=0 #19230

aschade commented Jan 13, 2018

jschendel Jan 13, 2018

jschendel Jan 13, 2018 •

edited

Loading

aschade Jan 13, 2018

aschade Jan 13, 2018 •

edited

Loading

jreback Jan 13, 2018

jreback Jan 13, 2018

aschade Jan 14, 2018

jreback Jan 14, 2018

aschade Jan 14, 2018 •

edited

Loading

jreback Jan 14, 2018

aschade Jan 14, 2018

jreback Jan 14, 2018

aschade Jan 14, 2018 •

edited

Loading

jreback Jan 14, 2018

aschade Jan 14, 2018

jreback Jan 13, 2018

jreback Jan 13, 2018

jreback Jan 13, 2018

codecov bot commented Jan 13, 2018 •

edited

Loading

aschade commented Jan 14, 2018

jreback Jan 15, 2018

jreback Jan 15, 2018

jreback left a comment

jreback Jan 16, 2018

TomAugspurger Jan 16, 2018

jreback Jan 16, 2018

TomAugspurger Jan 16, 2018

TomAugspurger Jan 16, 2018

TomAugspurger Jan 16, 2018

TomAugspurger Jan 16, 2018

jreback commented Jan 18, 2018

aschade commented Jan 18, 2018 via email


		data = [[1, 2, 3], [1, 2, 3]]

		@pytest.mark.parametrize('actual', [

Fix no raise dup index when using drop with axis=0 #19230

Fix no raise dup index when using drop with axis=0 #19230

Conversation

aschade commented Jan 13, 2018

Choose a reason for hiding this comment

jschendel Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aschade Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aschade Jan 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aschade Jan 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 13, 2018 • edited Loading

Codecov Report

aschade commented Jan 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Jan 18, 2018

aschade commented Jan 18, 2018 via email

jschendel Jan 13, 2018 •

edited

Loading

aschade Jan 13, 2018 •

edited

Loading

aschade Jan 14, 2018 •

edited

Loading

aschade Jan 14, 2018 •

edited

Loading

codecov bot commented Jan 13, 2018 •

edited

Loading