-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for fixed issues in Series[datetime64] #19072
Conversation
@jbrockmendel : To properly close #12534, you should also add documentation per the discussion. |
Codecov Report
@@ Coverage Diff @@
## master #19072 +/- ##
==========================================
- Coverage 91.54% 91.51% -0.03%
==========================================
Files 148 148
Lines 48804 48804
==========================================
- Hits 44676 44664 -12
- Misses 4128 4140 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were these fixed by a previous PR? can you reference it
res = dt - ser | ||
tm.assert_series_equal(res, -expected) | ||
|
||
def test_dt64tz_series_sub_dtitz(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like a random place to put this test. can you group with other tz type op tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
For one of the tests I know it was fixed by #19024. For the other I'm not sure when it got fixed (but certainly no later than 19024) |
thanks, if these issues are not in the whatsnew pls add (new PR). |
git diff upstream/master -u -- "*.py" | flake8 --diff