Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for fixed issues in Series[datetime64] #19072

Merged
merged 4 commits into from
Jan 5, 2018

Conversation

jbrockmendel
Copy link
Member

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Jan 4, 2018
@gfyoung
Copy link
Member

gfyoung commented Jan 4, 2018

@jbrockmendel : To properly close #12534, you should also add documentation per the discussion.

@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #19072 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19072      +/-   ##
==========================================
- Coverage   91.54%   91.51%   -0.03%     
==========================================
  Files         148      148              
  Lines       48804    48804              
==========================================
- Hits        44676    44664      -12     
- Misses       4128     4140      +12
Flag Coverage Δ
#multiple 89.89% <ø> (-0.03%) ⬇️
#single 41.63% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8496b...b2db46f. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were these fixed by a previous PR? can you reference it

res = dt - ser
tm.assert_series_equal(res, -expected)

def test_dt64tz_series_sub_dtitz(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a random place to put this test. can you group with other tz type op tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@jbrockmendel
Copy link
Member Author

To properly close #12534, you should also add documentation per the discussion

@gfyoung Can you expand on what you have in mind here?

@jbrockmendel
Copy link
Member Author

were these fixed by a previous PR? can you reference it

For one of the tests I know it was fixed by #19024. For the other I'm not sure when it got fixed (but certainly no later than 19024)

@jreback jreback added this to the 0.23.0 milestone Jan 5, 2018
@jreback jreback merged commit acbfdf8 into pandas-dev:master Jan 5, 2018
@jreback
Copy link
Contributor

jreback commented Jan 5, 2018

thanks, if these issues are not in the whatsnew pls add (new PR).

@jbrockmendel jbrockmendel deleted the close12534 branch January 5, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series[datetime64tz] - DatetimeIndex[tz] raises ValueError Negative timedeltas for deltas > 292 years
3 participants