Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (partial) linting to asvs #18620

Closed
wants to merge 1 commit into from

Conversation

jbrockmendel
Copy link
Member

  1. Add linting,
  2. fix a bunch of lint warnings,
  3. add ignore/excludes so that it passes for now.

@mroeschke
Copy link
Member

Just a heads up, #18611 is overhauling groupyby.py and passes my local flake8 check.

Also, I'd be much appreciated if you could replace from .pandas_vb_common import * with from .pandas_vb_common import setup # noqa. The setup function will set up the random seed for all the setup functions.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18620 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18620      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...a302e7f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18620 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18620      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
Flag Coverage Δ
#multiple 89.32% <ø> (ø) ⬆️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...a302e7f. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 4, 2017

yeah prefer these be linted / cleaned in smaller batches.

@jreback jreback closed this Dec 4, 2017
@jbrockmendel
Copy link
Member Author

Also, I'd be much appreciated if you could replace from .pandas_vb_common import * with from .pandas_vb_common import setup # noqa. The setup function will set up the random seed for all the setup functions.

@mroeschke I'll make a note of it for next time around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants