Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp/timedelta test cleanup #18619

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Conversation

jbrockmendel
Copy link
Member

More informative names in timedeltas tests

remove/merge redundant tests in timestamps. Separate some big test classes thematically.

Use pytest.parametrize in a few places

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2017

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on December 04, 2017 at 01:22 Hours UTC

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18619 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18619      +/-   ##
==========================================
- Coverage   91.46%   91.44%   -0.03%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47049      -11     
- Misses       4389     4400      +11
Flag Coverage Δ
#multiple 89.31% <ø> (-0.01%) ⬇️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/testing.py 81.99% <0%> (-0.2%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...9538c07. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #18619 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18619      +/-   ##
==========================================
- Coverage   91.46%   91.44%   -0.03%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47049      -11     
- Misses       4389     4400      +11
Flag Coverage Δ
#multiple 89.31% <ø> (-0.01%) ⬇️
#single 40.6% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/testing.py 81.99% <0%> (-0.2%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56195...9538c07. Read the comment docs.

@jreback jreback added Clean Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Dec 4, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 4, 2017
@jreback jreback merged commit fe34b32 into pandas-dev:master Dec 4, 2017
@jreback
Copy link
Contributor

jreback commented Dec 4, 2017

thanks!

@jreback jreback added the Datetime Datetime data dtype label Dec 4, 2017
@jbrockmendel jbrockmendel deleted the tslibs-tests branch December 8, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants