Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cimports #18556

Merged
merged 3 commits into from
Dec 3, 2017
Merged

Cleanup cimports #18556

merged 3 commits into from
Dec 3, 2017

Conversation

jbrockmendel
Copy link
Member

No description provided.

jreback
jreback reviewed Nov 29, 2017
View reviewed changes
pandas/_libs/tslib.pxd
@@ -1,3 +0,0 @@
from numpy cimport ndarray, int64_t

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in setup.py anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #18556 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18556      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files         164      164              
  Lines       49802    49802              
==========================================
- Hits        45496    45487       -9     
- Misses       4306     4315       +9
Flag Coverage Δ
#multiple 89.13% <ø> (ø) ⬆️
#single 40.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f562d...355a705. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 29, 2017 •
edited
Loading

Codecov Report

Merging #18556 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18556      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files         164      164              
  Lines       49802    49802              
==========================================
- Hits        45496    45487       -9     
- Misses       4306     4315       +9
Flag Coverage Δ
#multiple 89.13% <ø> (ø) ⬆️
#single 40.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f562d...f9cbfe9. Read the comment docs.

jreback
jreback requested changes Nov 29, 2017
View reviewed changes
pandas/_libs/src/inference.pyx
@@ -3,7 +3,7 @@ from decimal import Decimal
cimport util
cimport cython
from tslibs.nattype import NaT
from tslib cimport convert_to_tsobject
from tslibs.conversion cimport convert_to_tsobject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add conversion.pxd as a dep for lib.pyx (tslib.pyd should have been there)

@jreback jreback added the Clean label Nov 29, 2017
@jbrockmendel
Copy link
Member Author

ping

@jreback jreback added this to the 0.22.0 milestone Dec 3, 2017
@jreback jreback merged commit 6e56195 into pandas-dev:master Dec 3, 2017
@jreback
Copy link
Contributor

jreback commented Dec 3, 2017

thanks!

@jbrockmendel jbrockmendel deleted the cleanup2 branch December 3, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback