-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement libmissing; untangles _libs dependencies #18357
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
12a880e
implement _libs.missing; remove all cimports of libs._lib
jbrockmendel 528cec1
cimport checknull instead of import
jbrockmendel d6355fe
fixup import
jbrockmendel 5fea502
flake8 fixup
jbrockmendel 876f848
Move libmissing tests to test_missing
jbrockmendel 9dcf97c
move util._checknull_old --> missing._check_none_nan_inf_neginf
jbrockmendel 2cf1b21
add docstrings
jbrockmendel 44fbe90
edits per reviewer request
jbrockmendel f833419
Merge branch 'master' of https://github.com/pandas-dev/pandas into li…
jbrockmendel d2184f1
fixup missing import
jbrockmendel 5614df8
Merge branch 'master' of https://github.com/pandas-dev/pandas into li…
jbrockmendel a688996
Merge branch 'master' of https://github.com/pandas-dev/pandas into li…
jbrockmendel d1323fb
remove imports no longer used after merge
jbrockmendel ce185e0
Merge branch 'master' of https://github.com/pandas-dev/pandas into li…
jbrockmendel 6d8308f
use NPY_NAT instead of iNaT, range instead of C syntax
jbrockmendel e94e01f
add pxdfiles for _libs.lib
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
# prototypes for sharing | ||
|
||
cdef bint is_null_datetimelike(v) | ||
cpdef bint is_period(val) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# -*- coding: utf-8 -*- | ||
# cython: profile=False | ||
|
||
cdef bint is_null_datetimelike(v) | ||
cpdef bint checknull(object val) | ||
cpdef bint checknull_old(object val) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these could be cimports instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATM these are not
cdef