Revert "Revert "MAINT: Remove Long and WidePanel (#15748)" (#15802)" #18341

gfyoung · 2017-11-17T09:12:22Z

With statsmodels/statsmodels#3580 now resolved, we can safely revert #15802

codecov · 2017-11-17T10:24:26Z

Codecov Report

Merging #18341 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18341      +/-   ##
==========================================
+ Coverage   91.82%   91.83%   +<.01%     
==========================================
  Files         153      153              
  Lines       49503    49495       -8     
==========================================
- Hits        45458    45454       -4     
+ Misses       4045     4041       -4

Flag	Coverage Δ
#multiple	`90.23% <100%> (ø)`	⬆️
#single	`41.88% <100%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/panel.py	`97.87% <ø> (+0.57%)`	⬆️
pandas/core/api.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27581e9...854be64. Read the comment docs.

jorisvandenbossche · 2017-11-17T11:19:17Z

Let's still wait until there is an actual statsmodels release. At this point we don't know yet who of statsmodels or pandas will release first.

jreback · 2017-11-17T11:21:51Z

going to merge #18333 which will causes this to fail. We weren't fully testing things in the downstream.

jreback · 2017-11-17T11:29:24Z

@gfyoung go ahead and rebase. This should fail. We can decide whether to xfail the test at a later point.

gfyoung · 2017-11-17T17:11:43Z

Let's still wait until there is an actual statsmodels release. At this point we don't know yet who of statsmodels or pandas will release first.

@jorisvandenbossche : That's unfortunate, as they said that it would come out by end of summer. Not sure what happened there.

We can decide whether to xfail the test at a later point.

@jreback : Not sure what "the test" is, but yep, will do.

gfyoung · 2017-11-17T18:45:54Z

Ummm...@jreback : what test was supposed to fail? 😄

jorisvandenbossche · 2017-11-18T09:19:07Z

@jorisvandenbossche : That's unfortunate, as they said that it would come out by end of summer. Not sure what happened there.

Well, that's the reality of volunteer-based open source. It's indeed a bit annoying for us to have to keep it, but also not that costly.
We can just leave the PR open until the new statsmodels is out I would say.

gfyoung · 2017-11-18T09:29:37Z

Well, that's the reality of volunteer-based open source. It's indeed a bit annoying for us to have to keep it, but also not that costly.

Yeah...things happen. I have no problems waiting.

bashtage · 2017-11-18T20:00:23Z

Let's still wait until there is an actual statsmodels release. At this point we don't know yet who of statsmodels or pandas will release first.

IMO pandas should make this change since it provides incentive for statsmodels to drop a release.

jreback · 2017-11-19T00:44:06Z

@gfyoung once I merge this, it should fail: #18362

turns out was skipping the tests :<

jreback · 2017-11-19T00:44:41Z

Then I agree with @bashtage we should xfail this test and merge. but let it fail to prove first.

gfyoung · 2017-11-19T00:57:18Z

IMO pandas should make this change since it provides incentive for statsmodels to drop a release.

@bashtage : I actually hadn't thought of that. Also makes sense.

Then I agree with @bashtage we should xfail this test and merge. but let it fail to prove first.

Sounds good to me.

jreback · 2017-11-19T01:26:44Z

@gfyoung rebase and let's see

gfyoung · 2017-11-19T05:47:55Z

@jreback : Can confirm that Travis is failing as a result of your PR. I will @xfail the test once Circle and AppVeyor have finished.

gfyoung · 2017-11-19T07:36:19Z

@jreback : And adding @xfail does fix everything. All is green again.

jreback · 2017-11-19T15:00:01Z

pandas/tests/test_panel.py

@@ -2155,8 +2147,8 @@ def test_multiindex_get(self):
            assert (f1.items == [1, 2]).all()
            assert (f2.items == [1, 2]).all()

-            ind = MultiIndex.from_tuples([('a', 1), ('a', 2), ('b', 1)],


what does this last section compare?

Not entirely sure? I just saw this variable being assigned and not being used afterwards.

ok, if you can remove that (doesn't look like it does anything) would be great.

Sure thing. Done.

jreback · 2017-11-19T18:48:22Z

@TomAugspurger is there a statsmodel 0.9.0 release issue? (where we can reference this)

gfyoung · 2017-11-19T18:57:42Z

@jreback : Judging from the milestone search here, statsmodels/statsmodels#3431 might be it? The issue is a little sparse though.

TomAugspurger · 2017-11-19T19:00:43Z

I don't think so.

…

On Sun, Nov 19, 2017 at 12:48 PM, Jeff Reback ***@***.***> wrote: @TomAugspurger <https://github.com/tomaugspurger> is there a statsmodel 0.9.0 release issue? (where we can reference this) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18341 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIkZCSs0hXhfTkq3XIHnWUVno3pdEks5s4Hf5gaJpZM4Qhvfg> .

jorisvandenbossche · 2017-11-19T20:11:25Z

Still -1 on merging this. I would say let's try to convince them with words to do a release instead of by breaking their code.

jreback · 2017-11-19T20:13:15Z

ok

@gfyoung let's remove the xfail and just leave this PR until/when statsmodels can do a release.

jreback

@gfyoung I think can finally merge this as sm 0.9.0 is out.

jreback · 2018-05-16T11:01:42Z

doc/source/whatsnew/v0.23.0.txt

@@ -1079,6 +1079,8 @@ Removal of prior version deprecations/changes
  so operations would continue to work. This is now fully removed, so a ``Resampler`` will no longer forward compat operations (:issue:`20554`)
 - Remove long deprecated ``axis=None`` parameter from ``.replace()`` (:issue:`20271`)

+- The ``LongPanel`` and ``WidePanel`` classes have been removed (:issue:`10892`)


move to 0.24

Yep, will do. Finally! 😄

…andas-dev#15802)" This reverts commit 22f9d0d.

gfyoung · 2018-05-16T13:22:37Z

@jreback : All is green here.

jorisvandenbossche · 2018-05-16T13:32:26Z

Thanks!

gfyoung · 2018-05-16T14:15:28Z

Sure thing. Hopefully we won't need to revert this revert 😄

topper-123 · 2018-05-19T23:25:15Z

The deprecating issue was #10892

gfyoung added Clean Deprecate Functionality to remove in pandas Panel labels Nov 17, 2017

gfyoung added this to the 0.22.0 milestone Nov 17, 2017

gfyoung force-pushed the long-wide-panel branch from 11e962b to 6d89571 Compare November 17, 2017 17:12

gfyoung force-pushed the long-wide-panel branch from 6d89571 to c2bed28 Compare November 19, 2017 01:44

jreback requested changes Nov 19, 2017

View reviewed changes

jreback mentioned this pull request Nov 19, 2017

DEPR: deprecations log for removed issues #13777

Closed

gfyoung force-pushed the long-wide-panel branch from 705d08a to 1a3c73a Compare November 19, 2017 18:56

gfyoung force-pushed the long-wide-panel branch from 1a3c73a to 69344c4 Compare November 19, 2017 20:16

gfyoung force-pushed the long-wide-panel branch 4 times, most recently from 36b4866 to b252049 Compare April 30, 2018 00:37

jreback mentioned this pull request Apr 30, 2018

RLS: 0.23.0 #20531

Closed

71 tasks

gfyoung force-pushed the long-wide-panel branch 5 times, most recently from c34fe91 to 4e1810a Compare May 6, 2018 08:23

gfyoung force-pushed the long-wide-panel branch 7 times, most recently from 3e5f43c to 9bb6c82 Compare May 14, 2018 04:04

gfyoung force-pushed the long-wide-panel branch 2 times, most recently from 77618bd to 83ce112 Compare May 16, 2018 10:00

jreback requested changes May 16, 2018

View reviewed changes

Revert "Revert "MAINT: Remove Long and WidePanel (pandas-dev#15748)" (p…

854be64

…andas-dev#15802)" This reverts commit 22f9d0d.

gfyoung force-pushed the long-wide-panel branch 2 times, most recently from 28edc49 to 854be64 Compare May 16, 2018 11:57

jorisvandenbossche approved these changes May 16, 2018

View reviewed changes

jorisvandenbossche merged commit 501f041 into pandas-dev:master May 16, 2018

gfyoung deleted the long-wide-panel branch May 16, 2018 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Revert "MAINT: Remove Long and WidePanel (#15748)" (#15802)" #18341

Revert "Revert "MAINT: Remove Long and WidePanel (#15748)" (#15802)" #18341

gfyoung commented Nov 17, 2017

codecov bot commented Nov 17, 2017 •

edited

Loading

jorisvandenbossche commented Nov 17, 2017

jreback commented Nov 17, 2017

jreback commented Nov 17, 2017

gfyoung commented Nov 17, 2017

gfyoung commented Nov 17, 2017

jorisvandenbossche commented Nov 18, 2017

gfyoung commented Nov 18, 2017

bashtage commented Nov 18, 2017

jreback commented Nov 19, 2017

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017 •

edited

Loading

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017

gfyoung commented Nov 19, 2017

jreback Nov 19, 2017

gfyoung Nov 19, 2017

jreback Nov 19, 2017

gfyoung Nov 19, 2017

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017 •

edited

Loading

TomAugspurger commented Nov 19, 2017 via email

jorisvandenbossche commented Nov 19, 2017

jreback commented Nov 19, 2017

jreback left a comment

jreback May 16, 2018

gfyoung May 16, 2018 •

edited

Loading

gfyoung commented May 16, 2018

jorisvandenbossche commented May 16, 2018

gfyoung commented May 16, 2018

topper-123 commented May 19, 2018

Revert "Revert "MAINT: Remove Long and WidePanel (#15748)" (#15802)" #18341

Revert "Revert "MAINT: Remove Long and WidePanel (#15748)" (#15802)" #18341

Conversation

gfyoung commented Nov 17, 2017

codecov bot commented Nov 17, 2017 • edited Loading

Codecov Report

jorisvandenbossche commented Nov 17, 2017

jreback commented Nov 17, 2017

jreback commented Nov 17, 2017

gfyoung commented Nov 17, 2017

gfyoung commented Nov 17, 2017

jorisvandenbossche commented Nov 18, 2017

gfyoung commented Nov 18, 2017

bashtage commented Nov 18, 2017

jreback commented Nov 19, 2017

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017 • edited Loading

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017

gfyoung commented Nov 19, 2017

jreback Nov 19, 2017

Choose a reason for hiding this comment

gfyoung Nov 19, 2017

Choose a reason for hiding this comment

jreback Nov 19, 2017

Choose a reason for hiding this comment

gfyoung Nov 19, 2017

Choose a reason for hiding this comment

jreback commented Nov 19, 2017

gfyoung commented Nov 19, 2017 • edited Loading

TomAugspurger commented Nov 19, 2017 via email

jorisvandenbossche commented Nov 19, 2017

jreback commented Nov 19, 2017

jreback left a comment

Choose a reason for hiding this comment

jreback May 16, 2018

Choose a reason for hiding this comment

gfyoung May 16, 2018 • edited Loading

Choose a reason for hiding this comment

gfyoung commented May 16, 2018

jorisvandenbossche commented May 16, 2018

gfyoung commented May 16, 2018

topper-123 commented May 19, 2018

codecov bot commented Nov 17, 2017 •

edited

Loading

gfyoung commented Nov 19, 2017 •

edited

Loading

gfyoung commented Nov 19, 2017 •

edited

Loading

gfyoung May 16, 2018 •

edited

Loading