BUG: Use total_tie_count to normalize dense ranking #18297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #18296, for a `Series` with repeated values, `Series.rank(pct=True, method='dense').max()` may not be `<=1` as expected. This is due to the division of the ranks by the total number of elements in the `Series`, instead of the maximum rank assigned. Here we update the calculation.
|
I've confirmed that the updated code gives the expected result from the example in #18296. |
Codecov Report
@@ Coverage Diff @@
## master #18297 +/- ##
==========================================
- Coverage 91.4% 91.38% -0.02%
==========================================
Files 164 164
Lines 49880 49880
==========================================
- Hits 45592 45583 -9
- Misses 4288 4297 +9
Continue to review full report at Codecov.
|
|
how about some tests |
|
see #15630 (and linked PR soln but has comments). |
jreback
requested changes
Dec 28, 2017
| @@ -117,7 +117,7 @@ Reshaping | |||
| Numeric | |||
| ^^^^^^^ | |||
|
|
|||
| - | |||
| - Fixed incorrect maximum :func:`Series.rank` percentile when using the `dense` method with repeated values (:issue:`18296`) | |||
|
closing as stale. ping if you want to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAs reported in #18296, for a
Serieswith repeated values,Series.rank(pct=True, method='dense').max()may not be<=1as expected.This is due to the division of the ranks by the total number of elements in the
Series, instead of the maximum rank assigned. Here we update the calculation.