Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/DEPR: remove setter for MultiIndex levels/labels properties #18256

Merged

Conversation

jorisvandenbossche
Copy link
Member

Noticed this in another PR, this doesn't seem to be listed in our deprecations master issue #6581. But it is already deprecated since 0.13 (#4039)

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@7b5ca80). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18256   +/-   ##
=========================================
  Coverage          ?   91.39%           
=========================================
  Files             ?      164           
  Lines             ?    50092           
  Branches          ?        0           
=========================================
  Hits              ?    45780           
  Misses            ?     4312           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.2% <100%> (?)
#single 40.36% <100%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 96.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5ca80...a393159. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #18256 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18256      +/-   ##
==========================================
+ Coverage   91.38%   91.38%   +<.01%     
==========================================
  Files         164      164              
  Lines       49884    49879       -5     
==========================================
- Hits        45584    45582       -2     
+ Misses       4300     4297       -3
Flag Coverage Δ
#multiple 89.19% <100%> (+0.02%) ⬆️
#single 39.41% <100%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 96.38% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.25% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4c960...9c3ad6f. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

Failure only seems to be the clipboard one (which is known), and the BUILD_TEST.
Not sure why that last one is failing already tried to restart it some times)

@jreback
Copy link
Contributor

jreback commented Nov 13, 2017

Failure only seems to be the clipboard one (which is known), and the BUILD_TEST.
Not sure why that last one is failing already tried to restart it some times)

assume you have rebased on master. These failures are not longer.

@jreback
Copy link
Contributor

jreback commented Nov 13, 2017

your build looks old (e.g. not rebased)

@jreback
Copy link
Contributor

jreback commented Nov 13, 2017

lgtm otherwise (but push again anyhow)

@jorisvandenbossche
Copy link
Member Author

This was from a clean master, at the moment the PR was opened :-)

@jorisvandenbossche jorisvandenbossche merged commit 69472f9 into pandas-dev:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants