Add timestamp method+test; closes #17329 #17906

jbrockmendel · 2017-10-17T17:34:44Z

closes COMPAT: support Timestamp.timestamp() in py2.x #17329
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

jschendel · 2017-10-17T18:07:58Z

doc/source/whatsnew/v0.21.0.txt

@@ -235,6 +235,7 @@ Other Enhancements
 - Improved the import time of pandas by about 2.25x.  (:issue:`16764`)
 - :func:`read_json` and :func:`to_json` now accept a ``compression`` argument which allows them to transparently handle compressed files. (:issue:`17798`)
 - :func:`Series.reindex`, :func:`DataFrame.reindex`, :func:`Index.get_indexer` now support list-like argument for ``tolerance``. (:issue:`17367`)
+- :meth:`Timestamp.timestamp` is now available in python 2.7. (:issue:`17329`)


Nitpick: All other instances of "Python" in the whatsnew have a capitalized P.

jreback · 2017-10-17T22:45:12Z

pandas/_libs/tslib.pyx

@@ -1405,6 +1404,10 @@ cdef class _Timestamp(datetime):
        def __get__(self):
            return np.datetime64(self.value, 'ns')

+    def timestamp(self):
+        # py27 compat, see GH#17329
+        return self.value / 1e9


can you add a doc-string

jreback · 2017-10-17T22:45:29Z

pandas/tests/scalar/test_timestamp.py

+    def test_timestamp(self):
+        # Gh#17329
+        # tz-naive --> treat it as if it were UTC for purposes of timestamp()
+        ts = Timestamp.now()


test versus a datetime.timestamp() value here (as well)

e.g. ts.to_pydatetime().timestamp()

codecov · 2017-10-17T23:03:02Z

Codecov Report

Merging #17906 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17906      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       50105    50105              
==========================================
- Hits        45715    45706       -9     
- Misses       4390     4399       +9

Flag	Coverage Δ
#multiple	`89.03% <ø> (ø)`	⬆️
#single	`40.31% <ø> (-0.06%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.75% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf7f9a...a88419d. Read the comment docs.

codecov · 2017-10-17T23:03:26Z

Codecov Report

Merging #17906 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17906      +/-   ##
==========================================
+ Coverage   91.24%   91.25%   +0.01%     
==========================================
  Files         163      163              
  Lines       50173    50173              
==========================================
+ Hits        45778    45786       +8     
+ Misses       4395     4387       -8

Flag	Coverage Δ
#multiple	`89.06% <ø> (+0.03%)`	⬆️
#single	`40.29% <ø> (-0.05%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.75% <0%> (-0.1%)`	⬇️
pandas/plotting/_converter.py	`65.2% <0%> (+1.81%)`	⬆️
pandas/io/msgpack/_version.py	`44.65% <0%> (+1.9%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1e507...7992462. Read the comment docs.

jreback · 2017-10-17T23:11:12Z

doc/source/whatsnew/v0.21.0.txt

@@ -235,6 +235,7 @@ Other Enhancements
 - Improved the import time of pandas by about 2.25x.  (:issue:`16764`)
 - :func:`read_json` and :func:`to_json` now accept a ``compression`` argument which allows them to transparently handle compressed files. (:issue:`17798`)
 - :func:`Series.reindex`, :func:`DataFrame.reindex`, :func:`Index.get_indexer` now support list-like argument for ``tolerance``. (:issue:`17367`)
+- :meth:`Timestamp.timestamp` is now available in Python 2.7. (:issue:`17329`)


is this in api.rst?

jreback · 2017-10-17T23:12:04Z

pandas/tests/scalar/test_timestamp.py

+        # utsc is a different representation of the same time
+        assert tsc.timestamp() == utsc.timestamp()
+
+        if PY3:


is this not available in py2? on datetime?

Correct. The method was added to the stdlib datetime.datetime in py3.3

jreback · 2017-10-17T23:22:47Z

pandas/tests/scalar/test_timestamp.py

+        uts = ts.replace(tzinfo=utc)
+        assert ts.timestamp() == uts.timestamp()
+
+        tsc = Timestamp('2014-10-11 11:00:01.12345678', tz='US/Central')


can u maker sure test for mat is ok?

I don't understand the question.

jreback · 2017-10-21T14:08:01Z

pandas/tests/scalar/test_timestamp.py

+            dt = ts.to_pydatetime()
+            assert dt.timestamp() == round(ts.timestamp(), 6)
+
+        pytest.raises(ValueError, NaT.timestamp)


can you move this to the section where we test NaT (test_nat.py)

Come to think of it, should NaT.timestamp raise or return nan?

jreback · 2017-10-21T14:09:07Z

pandas/tests/scalar/test_timestamp.py

+        if PY3:
+            # should agree with datetime.timestamp method
+            dt = ts.to_pydatetime()
+            assert dt.timestamp() == round(ts.timestamp(), 6)


why do you need to round?

Because dt.timestamp() is the datetime.timestamp method which only has microsecond-precision.

exactly, you should not need to do this

jreback · 2017-10-21T14:09:59Z

pandas/_libs/tslib.pyx

+    def timestamp(self):
+        """Return POSIX timestamp as float."""
+        # py27 compat, see GH#17329
+        return self.value / 1e9


I think this is wrong if we have a nanosecond component. should issue a warning if we have one (I think its a print statement, but that's consistent with what we have now). add a test for this.

Why is it wrong with a nanosecond component? Is it a precision issue?

yes its not compatible with datetime.timestamp() (since you cannot construct one in datetime, we should not allow a time value which is invalid)

I'll make this change, will add follow-up to the tslibs todo list, since it isn't obvious to me that this is the correct decision.

bkmrkr · 2017-10-21T19:26:53Z

Please remove me from the list

On Tue, Oct 17, 2017 at 7:53 PM jbrockmendel ***@***.***> wrote: - closes #17329 <#17329> - tests added / passed - passes git diff upstream/master -u -- "*.py" | flake8 --diff - whatsnew entry ------------------------------ You can view, comment on, or merge this pull request online at: #17906 Commit Summary - Add timestamp method+test; closes #17329 - whatsnew entry File Changes - *M* doc/source/whatsnew/v0.21.0.txt <https://github.com/pandas-dev/pandas/pull/17906/files#diff-0> (1) - *M* pandas/_libs/tslib.pyx <https://github.com/pandas-dev/pandas/pull/17906/files#diff-1> (6) - *M* pandas/tests/scalar/test_timestamp.py <https://github.com/pandas-dev/pandas/pull/17906/files#diff-2> (12) Patch Links: - https://github.com/pandas-dev/pandas/pull/17906.patch - https://github.com/pandas-dev/pandas/pull/17906.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17906>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJfaxH6VMPu__Vl7ywaSM3mPR7NsBb7ks5stOkfgaJpZM4P8i8g> .

-- Greg Gurevich greggurevich@gmail.com cell: 1-917-504-7105

jreback · 2017-10-21T19:36:04Z

pandas/tests/scalar/test_nat.py

@@ -123,6 +123,11 @@ def test_round_nat(klass):
            assert round_method(freq) is ts


+def test_timestamp():


pls just add this where the others are (IOW in the list), don't special case this.

jreback · 2017-10-21T20:03:05Z

try. test where u take a min zero nanosecond Timestamp then do .timestamp() and create this as a datetime it will lose the nanoseconds

…libs-timestamps

jreback · 2017-10-27T22:04:04Z

thanks

(cherry picked from commit 5dd2ea0)

jbrockmendel added 3 commits October 17, 2017 10:27

Add timestamp method+test; closes pandas-dev#17329

f9e2ad5

whatsnew entry

aa7b06d

typo fixup tz-->tzinfo

4155b03

jschendel reviewed Oct 17, 2017

View reviewed changes

jbrockmendel added 3 commits October 17, 2017 11:46

fixup python-->Python

c73c2fe

Add timestamp method to NaT in py2

66d4a2b

fix docstring mismatch

54ebd13

jreback requested changes Oct 17, 2017

View reviewed changes

jreback added 2/3 Compat Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype labels Oct 17, 2017

add docstring, test against timestamp in py3

a88419d

jreback requested changes Oct 17, 2017

View reviewed changes

jbrockmendel added 5 commits October 17, 2017 16:33

add timestamp to api.rst

49accab

fixup missing import

698e688

typo fixup

5eed82b

fix timestamp test

715b740

add test for NaT.timestamp

b7747ec

jreback requested changes Oct 21, 2017

View reviewed changes

Move nat timestamp test to test_nat

237be98

jreback reviewed Oct 21, 2017

View reviewed changes

jbrockmendel added 2 commits October 21, 2017 12:54

round timestamp to 6 digits; merge nat test

a775671

remove rounding from timestamp test

8f6d8d5

jbrockmendel mentioned this pull request Oct 21, 2017

tslibs TODO list #17652

Closed

59 tasks

Merge branch 'master' of https://github.com/pandas-dev/pandas into ts…

580a1c6

…libs-timestamps

move whatsnew to 0.21.1

7992462

jreback added this to the 0.21.1 milestone Oct 27, 2017

jreback approved these changes Oct 27, 2017

View reviewed changes

jreback merged commit 5dd2ea0 into pandas-dev:master Oct 27, 2017

jreback added the Needs Backport label Oct 27, 2017

jbrockmendel deleted the tslibs-timestamps branch October 27, 2017 22:09

TomAugspurger mentioned this pull request Oct 30, 2017

TST: .timestamp() uses local timezone #18037

Closed

peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017

Add timestamp method+test; closes pandas-dev#17329 (pandas-dev#17906)

74ac010

No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

Add timestamp method+test; closes pandas-dev#17329 (pandas-dev#17906)

1f3865d

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017

Add timestamp method+test; closes pandas-dev#17329 (pandas-dev#17906)

5c23ef4

(cherry picked from commit 5dd2ea0)

TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017

Add timestamp method+test; closes #17329 (#17906)

4351758

(cherry picked from commit 5dd2ea0)

TomAugspurger removed the Needs Backport label Dec 11, 2017

chris-b1 mentioned this pull request Aug 21, 2018

Timestamp.timestamp() inconsistent with Datetime.timestamp() #22450

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timestamp method+test; closes #17329 #17906

Add timestamp method+test; closes #17329 #17906

jbrockmendel commented Oct 17, 2017

jschendel Oct 17, 2017

jreback Oct 17, 2017

jreback Oct 17, 2017

jreback Oct 17, 2017

codecov bot commented Oct 17, 2017

codecov bot commented Oct 17, 2017 •

edited

Loading

jreback Oct 17, 2017

jbrockmendel Oct 17, 2017

jreback Oct 17, 2017

jbrockmendel Oct 17, 2017

jreback Oct 17, 2017

jbrockmendel Oct 17, 2017

jreback Oct 20, 2017

jreback Oct 21, 2017

jbrockmendel Oct 21, 2017

jbrockmendel Oct 21, 2017

jreback Oct 21, 2017

jbrockmendel Oct 21, 2017

jreback Oct 21, 2017

jreback Oct 21, 2017

jbrockmendel Oct 21, 2017

jreback Oct 21, 2017

jbrockmendel Oct 21, 2017

bkmrkr commented Oct 21, 2017 via email

jreback Oct 21, 2017

jreback commented Oct 21, 2017

jreback commented Oct 27, 2017

		@@ -123,6 +123,11 @@ def test_round_nat(klass):
		assert round_method(freq) is ts


		def test_timestamp():

Add timestamp method+test; closes #17329 #17906

Add timestamp method+test; closes #17329 #17906

Conversation

jbrockmendel commented Oct 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 17, 2017

Codecov Report

codecov bot commented Oct 17, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkmrkr commented Oct 21, 2017 via email

Choose a reason for hiding this comment

jreback commented Oct 21, 2017

jreback commented Oct 27, 2017

codecov bot commented Oct 17, 2017 •

edited

Loading