ERR: Raise ValueError when week is passed in to_datetime format witho… #17819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Oct 8, 2017
| def test_week_without_day_and_calendar_year(self, date, format): | ||
| # GH16774 | ||
|
|
||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Instead of pytest.raises, use tm.assert_raises_regex to check for the error message as well.
Codecov Report
@@ Coverage Diff @@
## master #17819 +/- ##
==========================================
- Coverage 91.26% 91.24% -0.02%
==========================================
Files 163 163
Lines 49980 49986 +6
==========================================
- Hits 45613 45610 -3
- Misses 4367 4376 +9
Continue to review full report at Codecov.
|
jreback
requested changes
Oct 13, 2017
pandas/core/tools/datetimes.py
Outdated
| @@ -254,6 +254,16 @@ def _convert_listlike(arg, box, format, name=None, tz=tz): | |||
| require_iso8601 = not infer_datetime_format | |||
| format = None | |||
|
|
|||
| if format is not None: | |||
There was a problem hiding this comment.
can you move this check to
pandas/_libs/tslibs/strptime.pyx
its just closer to the code where we use it
|
lgtm ping on green. |
jreback
approved these changes
Oct 14, 2017
|
thanks @reidy-p |
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
ghost
pushed a commit
to reef-technologies/pandas
that referenced
this pull request
Oct 16, 2017
* upstream/master: (76 commits) CategoricalDtype construction: actually use fastpath (pandas-dev#17891) DEPR: Deprecate tupleize_cols in to_csv (pandas-dev#17877) BUG: Fix wrong column selection in drop_duplicates when duplicate column names (pandas-dev#17879) DOC: Adding examples to update docstring (pandas-dev#16812) (pandas-dev#17859) TST: Skip if no openpyxl in test_excel (pandas-dev#17883) TST: Catch read_html slow test warning (pandas-dev#17874) flake8 cleanup (pandas-dev#17873) TST: remove moar warnings (pandas-dev#17872) ENH: tolerance now takes list-like argument for reindex and get_indexer. (pandas-dev#17367) ERR: Raise ValueError when week is passed in to_datetime format witho… (pandas-dev#17819) TST: remove some deprecation warnings (pandas-dev#17870) Refactor index-as-string groupby tests and fix spurious warning (Bug 17383) (pandas-dev#17843) BUG: merging with a boolean/int categorical column (pandas-dev#17841) DEPR: Deprecate read_csv arguments fully (pandas-dev#17865) BUG: to_json - prevent various segfault conditions (GH14256) (pandas-dev#17857) CLN: Use pandas.core.common for None checks (pandas-dev#17816) BUG: set tz on DTI from fixed format HDFStore (pandas-dev#17844) RLS: v0.21.0rc1 Whatsnew cleanup (pandas-dev#17858) DEPR: Deprecate the convert parameter completely (pandas-dev#17831) ...
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut day or year (#16774)
git diff upstream/master -u -- "*.py" | flake8 --diff