Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: NaN in MultiIndex should not become a string (#7031) #16625

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

dsm054
Copy link
Contributor

@dsm054 dsm054 commented Jun 7, 2017

This verifies that NaNs in multiindexes don't become strings under outer joins or during arithmetic. This seems to have been fixed between 0.14.1 and 0.15.0.

Too minor and internal for a whatsnew update.

@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #16625 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16625      +/-   ##
==========================================
- Coverage   90.96%   90.93%   -0.03%     
==========================================
  Files         161      161              
  Lines       49263    49263              
==========================================
- Hits        44810    44798      -12     
- Misses       4453     4465      +12
Flag Coverage Δ
#multiple 88.69% <ø> (-0.03%) ⬇️
#single 40.22% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 63.23% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c17d4...9fe83d7. Read the comment docs.

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate MultiIndex Testing pandas testing functions or related to the test suite labels Jun 8, 2017
@jreback jreback added this to the 0.21.0 milestone Jun 8, 2017
@jreback jreback merged commit 722b386 into pandas-dev:master Jun 8, 2017
@jreback
Copy link
Contributor

jreback commented Jun 8, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants