Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove preference for pytest paradigm in assert_raises_regex #16518

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 27, 2017

tm.assert_raises_regex is a more compact version of the following:

with pytest.raises(<exc_type>) as exc_info:
   f(...)
exc_info.match(<regex>)

No reason for the docs to say that we prefer the pytest paradigm over our own.

xref #16511 (comment)

@TomAugspurger TomAugspurger merged commit ef487d9 into pandas-dev:master May 27, 2017
@codecov
Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #16518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16518   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         161      161           
  Lines       51063    51063           
=======================================
  Hits        46365    46365           
  Misses       4698     4698
Flag Coverage Δ
#multiple 88.63% <ø> (ø) ⬆️
#single 40.15% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 80.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6649157...a6ccc38. Read the comment docs.

@codecov
Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #16518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16518   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         161      161           
  Lines       51063    51063           
=======================================
  Hits        46365    46365           
  Misses       4698     4698
Flag Coverage Δ
#multiple 88.63% <ø> (ø) ⬆️
#single 40.15% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 80.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6649157...a6ccc38. Read the comment docs.

@gfyoung gfyoung deleted the assert-raises-regex-doc branch May 27, 2017 01:45
@TomAugspurger TomAugspurger added this to the 0.21.0 milestone May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants