DOC: update make.py script #16456
Merged
DOC: update make.py script #16456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I should probably just make a |
Not sure if it is that useful? Because you would still need to add a key for everybody wanting to access it no? (and I suppose adding a new user is also not that much of work?) |
TomAugspurger
approved these changes
May 23, 2017
Codecov Report
@@ Coverage Diff @@
## master #16456 +/- ##
==========================================
- Coverage 90.42% 90.42% -0.01%
==========================================
Files 161 161
Lines 51023 51023
==========================================
- Hits 46138 46137 -1
- Misses 4885 4886 +1
Continue to review full report at Codecov.
|
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
May 29, 2017
(cherry picked from commit 92372c7)
TomAugspurger
pushed a commit
that referenced
this pull request
May 30, 2017
(cherry picked from commit 92372c7)
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomAugspurger I updated the docs yesterday with this.
Not sure if it is needed to keep the possibility to pass a user (if you specify this in
.ssh/configyou don't need this, but the current code allows you to not have the user specified there)But I could also simplify and just remove the whole user thing.
(depending on that will also update the other one, upload_stable_pdf)