Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Groupby.cummin/max DataError on datetimes (#15561) #15569

Merged
merged 1 commit into from
Mar 5, 2017

Conversation

mroeschke
Copy link
Member

numeric_only=False set by default for groupby.cummin/cummax like groupby.max/min allows datetimes to work.

@jreback jreback added Bug Groupby Datetime Datetime data dtype labels Mar 4, 2017
@jreback
Copy link
Contributor

jreback commented Mar 4, 2017

lgtm. ping on green.

@jreback jreback added this to the 0.20.0 milestone Mar 4, 2017
@codecov-io
Copy link

Codecov Report

Merging #15569 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15569      +/-   ##
==========================================
- Coverage   91.05%   91.03%   -0.03%     
==========================================
  Files         137      137              
  Lines       49291    49283       -8     
==========================================
- Hits        44884    44863      -21     
- Misses       4407     4420      +13
Impacted Files Coverage Δ
pandas/core/groupby.py 94.99% <100%> (ø)
pandas/io/gbq.py 25% <0%> (-58.34%)
pandas/tools/merge.py 91.78% <0%> (-0.35%)
pandas/core/common.py 91.02% <0%> (-0.34%)
pandas/tseries/period.py 92.67% <0%> (-0.13%)
pandas/core/frame.py 97.83% <0%> (-0.1%)
pandas/tseries/index.py 95.32% <0%> (-0.1%)
pandas/indexes/base.py 96.23% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0b69a...5e5d70d. Read the comment docs.

@TomAugspurger TomAugspurger merged commit f5b7bcb into pandas-dev:master Mar 5, 2017
@TomAugspurger
Copy link
Contributor

Thanks!

@mroeschke mroeschke deleted the fix_15561 branch December 20, 2017 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cython version of groupby.cummax throws error on datetimes
4 participants