ENH: merge_asof() has left_index/right_index and left_by/right_by (#14253) #14426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be the first to admit that there is some kludge in here, identified by comments in the source code. There are some code paths that can only be hit during a I think for pandas 2.0 we'll need to take a more holistic view of how to do merges. |
Current coverage is 85.26% (diff: 87.23%)@@ master #14426 diff @@
==========================================
Files 140 140
Lines 50634 50660 +26
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43173 43193 +20
- Misses 7461 7467 +6
Partials 0 0
|
|
I've had to resubmit this PR as #14531 because I had to recreate my pandas fork. Long story. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff