WIP/ENH: reading older Stata versions, #11526 #14159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.24% (diff: 100%)@@ master #14159 diff @@
==========================================
Files 140 140
Lines 50563 50563
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43101 43101
Misses 7462 7462
Partials 0 0
|
|
can you add a whatnew in Bug Fixes. ping on green. |
|
can you rebase and push again |
|
@jreback I don't understand the issue with appveyor here |
|
need to rebase on master |
|
@jreback, looks OK now |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple file seems to read OK if we just treat it like other "old format" (version 104-115) files. However I do not currently have any documentation for this format. The only relevant resource I can find is the file
foreign/src/stataread.cin the Rforeignpackage sources:https://cran.r-project.org/src/contrib/foreign_0.8-66.tar.gz
It suggests some special handling for version 111 but I haven't had time to figure out exactly what it is doing.
git diff upstream/master | flake8 --diff