[WIP] ENH: add to_xarray conversion method #11950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @shoyer in preparation for deprecation of ndim > 2. |
73dbc03 to
2463456
Compare
| coords = [ (a,self._get_axis(a)) for a in self._AXIS_ORDERS ] | ||
| return xray.DataArray(self, | ||
| coords=coords, | ||
| ).to_dataset() |
There was a problem hiding this comment.
I'm not sure this makes sense. I would simply return an xray.DataArray here (no to_dataset), since that is probably what users want if they are using panels, etc.
There was a problem hiding this comment.
hmm, isn't by definition a DataArray single dtype? yes Panel are usually single dtypes, but can have multiple. I think also more consistent to always return a Dataset, yes?
however in either case these don't look dtype segregated (e.g. compared to say the converted DataFrame), am I doing something wrong?
2 tasks
jreback
added a commit
that referenced
this pull request
Feb 10, 2016
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
supersedes pandas-dev#11950 xref pandas-dev#10000 Author: Jeff Reback <jeff@reback.net> Closes pandas-dev#11972 from jreback/xarray and squashes the following commits: 85de0b7 [Jeff Reback] ENH: add to_xarray conversion method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #10000