Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'table' as Allowed orient Value in to_json Docs #22272

Closed
WillAyd opened this issue Aug 10, 2018 · 3 comments · Fixed by #22277
Closed

Add 'table' as Allowed orient Value in to_json Docs #22272

WillAyd opened this issue Aug 10, 2018 · 3 comments · Fixed by #22277
Labels
Docs good first issue IO JSON read_json, to_json, json_normalize

Comments

@WillAyd
Copy link
Member

WillAyd commented Aug 10, 2018

Right now the allowed values for Series and DataFrame objects are missing table as an allowed value for the orient parameter in to_json

https://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.to_json.html
@WillAyd WillAyd added Docs IO JSON read_json, to_json, json_normalize good first issue labels Aug 10, 2018
@luxedo
Copy link

luxedo commented Aug 10, 2018

Is it? Am I missing something?

screenshot from 2018-08-10 14-44-51

@WillAyd
Copy link
Member Author

WillAyd commented Aug 10, 2018

Yep - look a little further up in your screenshot at the subsection for Series and DataFrame.

Very minor / nuanced but good to clean up for consistency

@NikhilKumarM NikhilKumarM mentioned this issue Aug 11, 2018
Merged
4 tasks
@NikhilKumarM
Copy link
Contributor

NikhilKumarM commented Aug 11, 2018 •
edited
Loading

@WillAyd I have added 'table' as allowed orient Value in to_json Docs. Could you please review my PR and let me know if I have to make any changes.

WillAyd pushed a commit that referenced this issue Aug 11, 2018
@NikhilKumarM @WillAyd
Added table as Allowed orient Value in to_json Docs(#22272) (#22277)
0370740
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this issue Oct 1, 2018
@NikhilKumarM
Added table as Allowed orient Value in to_json Docs(pandas-dev#22272)…
d394855 
… (pandas-dev#22277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs good first issue IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added table as Allowed orient Value in to_json Docs(#22272)
3 participants
@WillAyd @luxedo @NikhilKumarM