Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test_mixed_freq_regular_first failing on master #16371

Closed
TomAugspurger opened this issue May 16, 2017 · 6 comments
Closed

TST: test_mixed_freq_regular_first failing on master #16371

TomAugspurger opened this issue May 16, 2017 · 6 comments
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite

Comments

@TomAugspurger
Copy link
Contributor

Started with https://travis-ci.org/pandas-dev/pandas/builds/232766866, which clearly (I think?) isn't to blame.

I don't see any differences in dependencies between https://travis-ci.org/pandas-dev/pandas/jobs/232654666 and https://travis-ci.org/pandas-dev/pandas/jobs/232766873 will dig in more later.

@TomAugspurger TomAugspurger added CI Continuous Integration Testing pandas testing functions or related to the test suite labels May 16, 2017
@jreback
Copy link
Contributor

jreback commented May 17, 2017

looks like maybe mpl 2.0.2? (not sure how recent it was)

@jorisvandenbossche
Copy link
Member

I cannot reproduce this locally, also not with matplotlib 2.0.2 (and also the succeeding travis build before it started failing already had 2.0.2)

@TomAugspurger
Copy link
Contributor Author

@tacaswell shot in the dark here, but any guesses what's up with these kinds of failures? e.g. https://travis-ci.org/pandas-dev/pandas/jobs/236416092#L2162 No worries if you don't have any ideas.

I haven't been able to confirm it, but these failures are consistent with what would happen if we plot onto an existing figure with a different datetime frequency. All figures should be closed between tests, but who knows? Maybe something weird with pytest-xdist? Another failure: https://travis-ci.org/TomAugspurger/pandas/jobs/233810539

@tacaswell
Copy link
Contributor

Collisions from the pyplot global state is plausible.

Does it work if you restart the test?

Flipping through the builds on master it looks like it sometimes passes and sometimes fails. In the mpl test suite we have had issue where one tests is missing the clean up logic (which in this case I assume is taken care of in by the class?). The dictionary iteration randomization means sometimes the sensitive test runs after a test that properly cleans up and sometimes not (at least I think that is the mechanism, have not dug too far into it).

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented May 30, 2017 via email

@tacaswell
Copy link
Contributor

Adding an explicit clf() might also help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

4 participants